From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9DE396E459; Fri, 19 Nov 2021 11:16:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9DE396E459 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1637309760; bh=v4UXncxT2ArQT0mItDFoTNEt9pcNEx7aSrvg32/c/PU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BwTMDwNCRR3TUiY8rRnK8eJSfN0vr0OxdMvDgQF5V1uiuv4of+VBSIbiyut26jbmB guUafFvmDKaAZsCKwP8DS0RKwOaO80msvqF+rPnjy37mclH+8mGyqHlcql7/mF+KYH biPUX5CwZGxdw4uyrEsoAzBiBG7Owxc8fO5v5G/0= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 181BA6E459 for ; Fri, 19 Nov 2021 11:15:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 181BA6E459 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mnz3u-0002ps-FG; Fri, 19 Nov 2021 11:15:58 +0300 Date: Fri, 19 Nov 2021 11:15:57 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20211119081557.GB48713@tarantool.org> References: <28f2d8fb-af9a-9a9f-023f-6295c118d2d6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <28f2d8fb-af9a-9a9f-023f-6295c118d2d6@tarantool.org> X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD927BBD05C2915ABC3F5F793E7CCBBEEA633125E1C7D4BB9B8182A05F5380850404C228DA9ACA6FE27C6957A8049582575973F3836A56C1E3D9099E58DF4D70418B7531D95CDE8E7A3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063720E5706DB08A2EAB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85827A34112CDDC9B3DE14DB8EE6BF8BE117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53DE4BA9173152F2F52AC0A2EDC7ECA34D71EDC83D47212AAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7506FE1F977233B9BB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AAC3D1FDB34D0488E73DC0E6A5DF94E46D0998BE8CB6C1FAFEA0476B6096677E3C5B3E53AC661F931D7E09C32AA3244C9FBCB2C265CF1D2930C8C00D463BCC9330363D8B7DA7DD44729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUkwcpHt8ZEe3Kpoate7g0A== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DE39EB0435E1801CF71645DC879205B9583D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: define default types for built-in functions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! My answer below. On Mon, Nov 15, 2021 at 10:53:25PM +0100, Vladislav Shpilevoy wrote: > Thanks for the patch! > > > +test:do_test( > > + "builtins-4.6", > > + function() > > + local res = {pcall(box.execute, [[SELECT LENGTH(?);]], {1})} > > + return {tostring(res[3])} > > Don't we usually use do_catchsql_test for such tests? The same for > 4.9, 4.13, 4.14. We do, but do_catchsql_test() does not support bindings, so we have to write tests like this.