From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: introduce MAP() function
Date: Mon, 15 Nov 2021 19:46:21 +0300 [thread overview]
Message-ID: <20211115164621.GC171607@tarantool.org> (raw)
In-Reply-To: <16ea8721-c98c-10ef-906f-8e1c35645084@tarantool.org>
Thank you for the review! My answer below.
On Sun, Nov 14, 2021 at 05:24:37PM +0100, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> The same as for the arrays. I am not sure this functions will be
> very helpful. MAP is still not usable because can't get/set individual
> values. And the function will be obsolete when proper syntax for maps
> is introduced.
True. I dropped this patch from the branch.
next prev parent reply other threads:[~2021-11-15 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 11:37 [Tarantool-patches] [PATCH v1 0/2] Introduce field type MAP to SQL Mergen Imeev via Tarantool-patches
2021-11-11 11:37 ` [Tarantool-patches] [PATCH v1 1/2] sql: introduce field type MAP Mergen Imeev via Tarantool-patches
2021-11-14 16:24 ` Vladislav Shpilevoy via Tarantool-patches
2021-11-15 16:45 ` Mergen Imeev via Tarantool-patches
2021-11-11 11:37 ` [Tarantool-patches] [PATCH v1 2/2] sql: introduce MAP() function Mergen Imeev via Tarantool-patches
2021-11-14 16:24 ` Vladislav Shpilevoy via Tarantool-patches
2021-11-15 16:46 ` Mergen Imeev via Tarantool-patches [this message]
2021-11-18 21:21 ` [Tarantool-patches] [PATCH v1 0/2] Introduce field type MAP to SQL Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115164621.GC171607@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 2/2] sql: introduce MAP() function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox