From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 05D0E7118D; Mon, 25 Oct 2021 12:57:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 05D0E7118D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1635155852; bh=ODw51mtkv2RiTTpjPXfffTz0x6qcvsY++2PSl16SCAw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VVuCuQHJs/nrzeXN5VBbXYcAmxaBVhgrbVwx9mMVVB06DIq6IGgKo8nOx/tA8u2YF uZ2WguDItwjS7J/UBjulHkmc8+P8ZdkbMOGN2KWhtLd/LxNfi9UrkM3ZFovas3x2H6 n6mbq9m7eVuh2sEsFrefsJX9gboqGFANQUTGT+yE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8EAAE7118D for ; Mon, 25 Oct 2021 12:57:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8EAAE7118D Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mewjQ-0005Gf-ON; Mon, 25 Oct 2021 12:57:29 +0300 Date: Mon, 25 Oct 2021 12:57:27 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20211025095727.GN36295@tarantool.org> References: <278cf14adddc65006253100ce12604626e748062.1633713433.git.imeevma@gmail.com> <51eb0bb4-b620-257e-5af3-10c8b23e7b2b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51eb0bb4-b620-257e-5af3-10c8b23e7b2b@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D1D35DBD2D15487E6FBC665C70D7247AB4BFB4F26BF422ED182A05F538085040A03D10F46151990C58E4E8E7B53212ECFCE88E08D99D2054444F29AD5E9F04E2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE779AAD18609327F83EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A60160C3319358EB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88165D3D4B21286B098F17F3C764034AF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CD1D040B6C1ECEA3F43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A514DF389B545DB54C95B534ECC6F3329A12E31A49A93DA8BFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34682FD2D2951524C5FD078AD161A46019B987AAA0D2525242DA4EB8B0D730F6CD76C74147756646E21D7E09C32AA3244CF46443D8CEA58591A470E5F60295D6FF69B6CAE0477E908D729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPL6H901iH3HoHBe2WdpRug== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D622712DF4D5B5FBF7324AF301DA8FE1A83D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 20/21] sql: remove MEM_Term flag X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! My answers, diff and new patch below. On Fri, Oct 15, 2021 at 12:47:33AM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > > diff --git a/src/box/sql/printf.c b/src/box/sql/printf.c > > index b4ab0d0f9..f261a731c 100644 > > --- a/src/box/sql/printf.c > > +++ b/src/box/sql/printf.c > > @@ -160,8 +160,22 @@ getTextArg(PrintfArguments * p) > > { > > if (p->nArg <= p->nUsed) > > return 0; > > - struct Mem *mem = p->apArg[p->nUsed++]; > > - return (char *)mem_as_str0(mem); > > + struct Mem mem; > > + mem_create(&mem); > > + mem_copy(&mem, p->apArg[p->nUsed++]); > > 1. mem_copy_as_ephemeral() would be enough. But would be even > better to have mem_snprintf() which would work like snprintf - > save string representation of mem into a provided buffer and > return how many bytes written / need to be written. This though > could be postponed indefinitely, I don't mind. > I wrote mem_snprintf (), but decided to introduce it a little later, as there are a couple of questions that need to be answered. > > + if (mem_to_str(&mem) != 0) { > > + mem_destroy(&mem); > > + return NULL; > > + } > > + char *str = region_alloc(&fiber()->gc, mem.n + 1); > > 2. printf is called for each row. Which means it will leak the > region. You can either do the snprintf-thing described above to > write directly into the needed buffer, or at least cleanup the > region using a save point in the end of sqlVXPrintf(). > I edited this code so that now the line will be freed correctly. > > diff --git a/src/box/sql/whereexpr.c b/src/box/sql/whereexpr.c > > index 6849f13ec..ad064d500 100644 > > --- a/src/box/sql/whereexpr.c > > +++ b/src/box/sql/whereexpr.c > > @@ -307,12 +307,18 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, > > > > op = pRight->op; > > if (op == TK_VARIABLE) { > > - Vdbe *pReprepare = pParse->pReprepare; > > - int iCol = pRight->iColumn; > > - pVal = sqlVdbeGetBoundValue(pReprepare, iCol); > > - if (pVal != NULL && mem_is_str(pVal)) { > > - if (mem_as_str0(pVal) == NULL) > > + var = vdbe_get_bound_value(pParse->pReprepare, > > + pRight->iColumn - 1); > > + if (var != NULL && mem_is_str(var)) { > > + uint32_t size = var->n + 1; > > + char *str = region_alloc(&fiber()->gc, size); > > 3. You leak the fiber's region. AFAIR, it is not cleaned up in the > end of parsing. Try to use pParse->region. > Thanks, fixed. Also, I added region_truncate() at the end of the function. > > + if (str == NULL) { > > + diag_set(OutOfMemory, size, "region", "str"); > > return -1; > > + } > > + memcpy(str, var->z, var->n); > > + str[var->n] = '\0'; > > + z = str; > > } Diff: diff --git a/src/box/sql/printf.c b/src/box/sql/printf.c index 066aaed9e..2c9fcd467 100644 --- a/src/box/sql/printf.c +++ b/src/box/sql/printf.c @@ -167,11 +167,9 @@ getTextArg(PrintfArguments * p) mem_destroy(&mem); return NULL; } - char *str = region_alloc(&fiber()->gc, mem.n + 1); - if (str == NULL) { - diag_set(OutOfMemory, mem.n + 1, "region", "str"); + char *str = sqlDbMallocRawNN(sql_get(), mem.n + 1); + if (str == NULL) return NULL; - } memcpy(str, mem.z, mem.n); str[mem.n] = '\0'; mem_destroy(&mem); @@ -691,6 +689,7 @@ sqlVXPrintf(StrAccum * pAccum, /* Accumulate results here */ if (bArgList) { bufpt = getTextArg(pArgList); c = bufpt ? bufpt[0] : 0; + zExtra = bufpt; } else { c = va_arg(ap, int); } @@ -711,7 +710,7 @@ sqlVXPrintf(StrAccum * pAccum, /* Accumulate results here */ case etDYNSTRING: if (bArgList) { bufpt = getTextArg(pArgList); - xtype = etSTRING; + xtype = etDYNSTRING; } else { bufpt = va_arg(ap, char *); } @@ -741,6 +740,7 @@ sqlVXPrintf(StrAccum * pAccum, /* Accumulate results here */ if (bArgList) { escarg = getTextArg(pArgList); + zExtra = escarg; } else { escarg = va_arg(ap, char *); } diff --git a/src/box/sql/whereexpr.c b/src/box/sql/whereexpr.c index ad064d500..08a1b4e3a 100644 --- a/src/box/sql/whereexpr.c +++ b/src/box/sql/whereexpr.c @@ -268,7 +268,6 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, int cnt; /* Database connection. */ sql *db = pParse->db; - const struct Mem *var = NULL; /* Opcode of pRight. */ int op; /* Result code to return. */ @@ -306,12 +305,15 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, return 0; op = pRight->op; + struct region *region = &pParse->region; + size_t svp = region_used(region); if (op == TK_VARIABLE) { - var = vdbe_get_bound_value(pParse->pReprepare, - pRight->iColumn - 1); + Vdbe *pReprepare = pParse->pReprepare; + int iCol = pRight->iColumn; + const struct Mem *var = vdbe_get_bound_value(pReprepare, iCol); if (var != NULL && mem_is_str(var)) { uint32_t size = var->n + 1; - char *str = region_alloc(&fiber()->gc, size); + char *str = region_alloc(region, size); if (str == NULL) { diag_set(OutOfMemory, size, "region", "str"); return -1; @@ -362,6 +364,7 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, } } + region_truncate(region, svp); rc = (z != 0); return rc; } New patch: commit fa3a78f95d3391c1629e31e2618d956c9ece4d14 Author: Mergen Imeev Date: Thu Oct 7 17:40:14 2021 +0300 sql: remove MEM_Term flag This patch removes the MEM_Term flag, because after changes in the SQL built-in functions, this flag is no longer used. Needed for #4145 diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c index 4150a24f0..1f5df3332 100644 --- a/src/box/sql/mem.c +++ b/src/box/sql/mem.c @@ -346,21 +346,18 @@ void mem_set_str0_ephemeral(struct Mem *mem, char *value) { set_str_const(mem, value, strlen(value), MEM_Ephem); - mem->flags |= MEM_Term; } void mem_set_str0_static(struct Mem *mem, char *value) { set_str_const(mem, value, strlen(value), MEM_Static); - mem->flags |= MEM_Term; } void mem_set_str0_allocated(struct Mem *mem, char *value) { set_str_dynamic(mem, value, strlen(value), 0); - mem->flags |= MEM_Term; } int @@ -392,7 +389,6 @@ mem_copy_str0(struct Mem *mem, const char *value) if (mem_copy_str(mem, value, len + 1) != 0) return -1; mem->n = len; - mem->flags |= MEM_Term; return 0; } @@ -657,24 +653,12 @@ int_to_str0(struct Mem *mem) return mem_copy_str0(mem, str); } -static inline int -str_to_str0(struct Mem *mem) -{ - assert(mem->type == MEM_TYPE_STR); - if (sqlVdbeMemGrow(mem, mem->n + 1, 1) != 0) - return -1; - mem->z[mem->n] = '\0'; - mem->flags |= MEM_Term; - mem->flags &= ~MEM_Scalar; - return 0; -} - static inline int str_to_bin(struct Mem *mem) { assert(mem->type == MEM_TYPE_STR); mem->type = MEM_TYPE_BIN; - mem->flags &= ~(MEM_Term | MEM_Scalar); + mem->flags &= ~MEM_Scalar; return 0; } @@ -725,18 +709,6 @@ bin_to_str(struct Mem *mem) return 0; } -static inline int -bin_to_str0(struct Mem *mem) -{ - assert(mem->type == MEM_TYPE_BIN); - if (sqlVdbeMemGrow(mem, mem->n + 1, 1) != 0) - return -1; - mem->z[mem->n] = '\0'; - mem->type = MEM_TYPE_STR; - mem->flags = MEM_Term; - return 0; -} - static inline int bin_to_uuid(struct Mem *mem) { @@ -1002,7 +974,7 @@ double_to_str0(struct Mem *mem) sql_snprintf(BUF_SIZE, mem->z, "%!.15g", mem->u.r); mem->n = strlen(mem->z); mem->type = MEM_TYPE_STR; - mem->flags = MEM_Term; + mem->flags = 0; return 0; } @@ -1284,39 +1256,6 @@ mem_to_number(struct Mem *mem) return -1; } -int -mem_to_str0(struct Mem *mem) -{ - assert(mem->type < MEM_TYPE_INVALID); - switch (mem->type) { - case MEM_TYPE_STR: - if ((mem->flags & MEM_Term) != 0) { - mem->flags &= ~MEM_Scalar; - return 0; - } - return str_to_str0(mem); - case MEM_TYPE_INT: - case MEM_TYPE_UINT: - return int_to_str0(mem); - case MEM_TYPE_DOUBLE: - return double_to_str0(mem); - case MEM_TYPE_BOOL: - return bool_to_str0(mem); - case MEM_TYPE_BIN: - return bin_to_str0(mem); - case MEM_TYPE_MAP: - return map_to_str0(mem); - case MEM_TYPE_ARRAY: - return array_to_str0(mem); - case MEM_TYPE_UUID: - return uuid_to_str0(mem); - case MEM_TYPE_DEC: - return dec_to_str0(mem); - default: - return -1; - } -} - int mem_to_str(struct Mem *mem) { @@ -1763,15 +1702,6 @@ mem_get_bool(const struct Mem *mem, bool *b) return -1; } -int -mem_get_str0(const struct Mem *mem, const char **s) -{ - if (mem->type != MEM_TYPE_STR || (mem->flags & MEM_Term) == 0) - return -1; - *s = mem->z; - return 0; -} - int mem_get_bin(const struct Mem *mem, const char **s) { @@ -1814,7 +1744,7 @@ mem_copy(struct Mem *to, const struct Mem *from) to->szMalloc = sqlDbMallocSize(to->db, to->zMalloc); memcpy(to->zMalloc, to->z, to->n); to->z = to->zMalloc; - to->flags &= MEM_Term; + to->flags = 0; return 0; } @@ -1831,7 +1761,7 @@ mem_copy_as_ephemeral(struct Mem *to, const struct Mem *from) return; if ((to->flags & (MEM_Static | MEM_Ephem)) != 0) return; - to->flags &= MEM_Term; + to->flags = 0; to->flags |= MEM_Ephem; return; } diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h index d2e9cc135..1ef8a945b 100644 --- a/src/box/sql/mem.h +++ b/src/box/sql/mem.h @@ -98,13 +98,6 @@ struct Mem { /** MEM is of SCALAR meta-type. */ #define MEM_Scalar 0x0002 #define MEM_Cleared 0x0200 /* NULL set by OP_Null, not from data */ - -/* Whenever Mem contains a valid string or blob representation, one of - * the following flags must be set to determine the memory management - * policy for Mem.z. The MEM_Term flag tells us whether or not the - * string is \000 or \u0000 terminated - */ -#define MEM_Term 0x0400 /* String rep is nul terminated */ #define MEM_Static 0x1000 /* Mem.z points to a static string */ #define MEM_Ephem 0x2000 /* Mem.z points to an ephemeral string */ @@ -610,14 +603,6 @@ mem_to_number(struct Mem *mem); int mem_to_str(struct Mem *mem); -/** - * Convert the given MEM to STRING. This function and the function above define - * the rules that are used to convert values of all other types to STRING. In - * this function, the string received after convertion is NULL-terminated. - */ -int -mem_to_str0(struct Mem *mem); - /** Convert the given MEM to given type according to explicit cast rules. */ int mem_cast_explicit(struct Mem *mem, enum field_type type); @@ -722,27 +707,6 @@ mem_get_bool_unsafe(const struct Mem *mem) return b; } -/** - * Return value for MEM of STRING type if MEM contains a NULL-terminated string. - * Otherwise convert value of the MEM to NULL-terminated string if possible and - * return converted value. Original MEM is not changed. - */ -int -mem_get_str0(const struct Mem *mem, const char **s); - -/** - * Return value for MEM of STRING type if MEM contains NULL-terminated string. - * Otherwise convert MEM to MEM of string type that contains NULL-terminated - * string and return its value. Return NULL if conversion is impossible. - */ -static inline const char * -mem_as_str0(struct Mem *mem) -{ - if (mem_to_str0(mem) != 0) - return NULL; - return mem->z; -} - /** * Return value for MEM of VARBINARY type. For MEM of all other types convert * value of the MEM to VARBINARY if possible and return converted value. diff --git a/src/box/sql/printf.c b/src/box/sql/printf.c index 5b61646e3..8da7c9878 100644 --- a/src/box/sql/printf.c +++ b/src/box/sql/printf.c @@ -160,8 +160,20 @@ getTextArg(PrintfArguments * p) { if (p->nArg <= p->nUsed) return 0; - struct Mem *mem = &p->apArg[p->nUsed++]; - return (char *)mem_as_str0(mem); + struct Mem mem; + mem_create(&mem); + mem_copy_as_ephemeral(&mem, &p->apArg[p->nUsed++]); + if (mem_to_str(&mem) != 0) { + mem_destroy(&mem); + return NULL; + } + char *str = sqlDbMallocRawNN(sql_get(), mem.n + 1); + if (str == NULL) + return NULL; + memcpy(str, mem.z, mem.n); + str[mem.n] = '\0'; + mem_destroy(&mem); + return str; } /* @@ -677,6 +689,7 @@ sqlVXPrintf(StrAccum * pAccum, /* Accumulate results here */ if (bArgList) { bufpt = getTextArg(pArgList); c = bufpt ? bufpt[0] : 0; + zExtra = bufpt; } else { c = va_arg(ap, int); } @@ -697,7 +710,7 @@ sqlVXPrintf(StrAccum * pAccum, /* Accumulate results here */ case etDYNSTRING: if (bArgList) { bufpt = getTextArg(pArgList); - xtype = etSTRING; + xtype = etDYNSTRING; } else { bufpt = va_arg(ap, char *); } @@ -727,6 +740,7 @@ sqlVXPrintf(StrAccum * pAccum, /* Accumulate results here */ if (bArgList) { escarg = getTextArg(pArgList); + zExtra = escarg; } else { escarg = va_arg(ap, char *); } diff --git a/src/box/sql/vdbe.h b/src/box/sql/vdbe.h index e482926b2..22e3370a2 100644 --- a/src/box/sql/vdbe.h +++ b/src/box/sql/vdbe.h @@ -256,6 +256,9 @@ vdbe_metadata_set_col_autoincrement(struct Vdbe *p, int idx); int vdbe_metadata_set_col_span(struct Vdbe *p, int idx, const char *span); +const struct Mem * +vdbe_get_bound_value(struct Vdbe *vdbe, int id); + void sqlVdbeCountChanges(Vdbe *); sql *sqlVdbeDb(Vdbe *); void sqlVdbeSetSql(Vdbe *, const char *z, int n); @@ -264,7 +267,6 @@ void sqlVdbeSwap(Vdbe *, Vdbe *); struct VdbeOp * sqlVdbeTakeOpArray(struct Vdbe *p, int *pnOp); -sql_value *sqlVdbeGetBoundValue(Vdbe *, int); char *sqlVdbeExpandSql(Vdbe *, const char *); /** diff --git a/src/box/sql/vdbeaux.c b/src/box/sql/vdbeaux.c index f5a84956c..5e7a1caff 100644 --- a/src/box/sql/vdbeaux.c +++ b/src/box/sql/vdbeaux.c @@ -2280,31 +2280,12 @@ sqlVdbeDb(Vdbe * v) return v->db; } -/* - * Return a pointer to an sql_value structure containing the value bound - * parameter iVar of VM v. Except, if the value is an SQL NULL, return - * 0 instead. Unless it is NULL, apply type to the value before returning it. - * - * The returned value must be freed by the caller using sqlValueFree(). - */ -sql_value * -sqlVdbeGetBoundValue(struct Vdbe *v, int iVar) -{ - assert(iVar > 0); - if (v) { - Mem *pMem = &v->aVar[iVar - 1]; - if (!mem_is_null(pMem)) { - sql_value *pRet = sqlValueNew(v->db); - if (pRet == NULL) - return NULL; - if (mem_copy(pRet, pMem) != 0) { - sqlValueFree(pRet); - return NULL; - } - return pRet; - } - } - return 0; +const struct Mem * +vdbe_get_bound_value(struct Vdbe *vdbe, int id) +{ + if (vdbe == NULL || id < 0 || id >= vdbe->nVar) + return NULL; + return &vdbe->aVar[id]; } void diff --git a/src/box/sql/whereexpr.c b/src/box/sql/whereexpr.c index 6849f13ec..08a1b4e3a 100644 --- a/src/box/sql/whereexpr.c +++ b/src/box/sql/whereexpr.c @@ -268,7 +268,6 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, int cnt; /* Database connection. */ sql *db = pParse->db; - sql_value *pVal = 0; /* Opcode of pRight. */ int op; /* Result code to return. */ @@ -306,13 +305,22 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, return 0; op = pRight->op; + struct region *region = &pParse->region; + size_t svp = region_used(region); if (op == TK_VARIABLE) { Vdbe *pReprepare = pParse->pReprepare; int iCol = pRight->iColumn; - pVal = sqlVdbeGetBoundValue(pReprepare, iCol); - if (pVal != NULL && mem_is_str(pVal)) { - if (mem_as_str0(pVal) == NULL) + const struct Mem *var = vdbe_get_bound_value(pReprepare, iCol); + if (var != NULL && mem_is_str(var)) { + uint32_t size = var->n + 1; + char *str = region_alloc(region, size); + if (str == NULL) { + diag_set(OutOfMemory, size, "region", "str"); return -1; + } + memcpy(str, var->z, var->n); + str[var->n] = '\0'; + z = str; } assert(pRight->op == TK_VARIABLE || pRight->op == TK_REGISTER); } else if (op == TK_STRING) { @@ -356,8 +364,8 @@ like_optimization_is_valid(Parse *pParse, Expr *pExpr, Expr **ppPrefix, } } + region_truncate(region, svp); rc = (z != 0); - sqlValueFree(pVal); return rc; }