From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3A30C6D3F5; Mon, 25 Oct 2021 11:38:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3A30C6D3F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1635151094; bh=5KbHAn/ghaoJShK+l4NyNaD7zU/uKeFN+dq1N6hT3QA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=WwZOkPnwjccGCqcb4uGnSW+IgATf7igjaNlS6Jmh/XHqdZuLxCxHoHhp6b4LIjXIs XuS+ypa+Mt0s3XrGSSPaRHfCpAadfBv4X4K154sYqfewZzZpRpmbd/AKizv0OL4i1J shdKAsUZ+IGVMcVCJEJqETeP8uCZiMBJ1lZ8QN9E= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BA02F6D3F5 for ; Mon, 25 Oct 2021 11:38:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA02F6D3F5 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mevUi-0001j1-2H; Mon, 25 Oct 2021 11:38:12 +0300 Date: Mon, 25 Oct 2021 11:38:10 +0300 To: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20211025083810.GI36295@tarantool.org> References: <6520c5c2bc6f2a4e9dfd224cf2162bf1fc130dd5.1633713432.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6520c5c2bc6f2a4e9dfd224cf2162bf1fc130dd5.1633713432.git.imeevma@gmail.com> X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C7814344C8C501C81DF2D982FCC3642A10B25E0CD3D2314B182A05F5380850405ACC5C608DD57CFFCDE1256EAE794FD4669719572A9D0E7247068EB3C1E92C7B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748C26B83F2B024408638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85AD1CFE59E0CF4053543CB60B7DB920B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A52BDF86FBE9A4829D312CBCE9D01AB60F011D9FC080F82BEED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3482189E76C6218D8FA7EFE30A51C285FB22A30EC759D3B78DD6492E5159A4DE42FBE0B97BB5617AC21D7E09C32AA3244C130D8E29B26685646496F2B59CB832CA3A92A9747B6CC886729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPL6H901iH3HXUMHDFAIPDw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D0B617A4AAAE4102003B202EAEB72157C83D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 12/21] sql: rework UUID() function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! I added a description to the function. On Fri, Oct 08, 2021 at 08:31:55PM +0300, Mergen Imeev via Tarantool-patches wrote: diff --git a/src/box/sql/func.c b/src/box/sql/func.c index 0d9002ac8..a32dd8fb6 100644 --- a/src/box/sql/func.c +++ b/src/box/sql/func.c @@ -984,7 +984,11 @@ func_row_count(struct sql_context *ctx, int argc, struct Mem *argv) return mem_set_uint(ctx->pOut, sql_get()->nChange); } -/** Implementation of the UUID() function. */ +/** + * Implementation of the UUID() function. + * + * Returns a randomly generated UUID value. + */ static void func_uuid(struct sql_context *ctx, int argc, struct Mem *argv) {