From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4727B6D3F5; Mon, 25 Oct 2021 11:37:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4727B6D3F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1635151049; bh=AmnHc5qqtItdKrnOEl8wwtufKxE8efzFYkmQ5dpsfog=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fGz/Nex9aoP0eF2c3sMlQSgkZ9XyHterFg3TteXG2m/DiokldAZdh0wyb9JnKFLNZ V2lRVbg1XUcix+QirJldnX5AYT9WRw5GPNUooiAPc1F2x1KyMw5xn/ef8y5gbUs1zW qnKSbiex0S65O9wgEow8abD8ZxhBt+W28CGcCEss= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8ABAD6D3F5 for ; Mon, 25 Oct 2021 11:37:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8ABAD6D3F5 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mevTy-0001MN-Vg; Mon, 25 Oct 2021 11:37:27 +0300 Date: Mon, 25 Oct 2021 11:37:25 +0300 To: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20211025083725.GH36295@tarantool.org> References: <26c9ec972d4ce5662fa99194d78789bb0e445281.1633713432.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <26c9ec972d4ce5662fa99194d78789bb0e445281.1633713432.git.imeevma@gmail.com> X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9C7814344C8C501C8A4649CC2A06649B6E8605CEAE0E6D1E6182A05F538085040C4356D201AFB4A72E7F71877DA2BB129754009C5F11DD1CD29C543F64824E418 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748424D8FCCA3295D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CCB3450E91739F8A09C6FC07AE4BBA24117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5355C3B5D6BDB38B8C93881D37A9C708257651B1396A459D6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F0A5F58274334C957858F7A176DE0F8636A46CFEF40EF573FD8E4B8D53B29ADE00DE6F33076A240B1D7E09C32AA3244CED9AC5FEB20FF2DA3F15088843A233637C0C08F7987826B9729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPL6H901iH3Gy2ONeNRck0A== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DAF9BA633E91205B77C9898A14DA1BED483D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 08/21] sql: refactor ZEROBLOB() function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! I added a description for the function. On Fri, Oct 08, 2021 at 08:31:46PM +0300, Mergen Imeev via Tarantool-patches wrote: diff --git a/src/box/sql/func.c b/src/box/sql/func.c index 670bed565..22704a9be 100644 --- a/src/box/sql/func.c +++ b/src/box/sql/func.c @@ -913,7 +913,12 @@ func_randomblob(struct sql_context *ctx, int argc, struct Mem *argv) mem_set_bin_allocated(ctx->pOut, res, len); } -/** Implementation of the ZEROBLOB() function. */ +/** + * Implementation of the ZEROBLOB() function. + * + * This function returns a zero-filled VARBINARY value. The size of this value + * is specified as an argument of the function. + */ static void func_zeroblob(struct sql_context *ctx, int argc, struct Mem *argv) {