From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DC8A76D3F5; Mon, 25 Oct 2021 11:35:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DC8A76D3F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1635150928; bh=FQzkZpjUgdmDGPRuCYHV4+Z5/gL9TnliL1X7LSjYZCQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=S7VtaKfaBuzf2Ro2T9F8AwdN9r5lYHWxJbBPuE/L70SpS14Jh8LajwY0JDCqf53iz 4HCozN+cFW5ma0QKAuKcTE7TjQUC6Lk4JLN1kctD5ip8tkm/DqyO0h6lvXXeivtUkZ y3QVYQ+rrAaBIrlua0cUY87T5+Q8Nzuva/aQqi+c= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DA5C56D3F5 for ; Mon, 25 Oct 2021 11:35:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DA5C56D3F5 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mevS0-00007u-Su; Mon, 25 Oct 2021 11:35:25 +0300 Date: Mon, 25 Oct 2021 11:35:23 +0300 To: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20211025083523.GF36295@tarantool.org> References: <5bad6fa91651dbf2877b64b3a92e02c42853165c.1633713432.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5bad6fa91651dbf2877b64b3a92e02c42853165c.1633713432.git.imeevma@gmail.com> X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9C7814344C8C501C83E7F929BE7EA67118FCDA824C75B5BF5182A05F5380850406FD0CC26AF353A75D51A72F73D3C82AB35E467E921F225872111AB7101553D18 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DA223B75F41C64628638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8888F0F031295B96AE79DF8DE197E2580117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50586D2C678351386E09FB6A6DEA0CF06D6 X-C1DE0DAB: 0D63561A33F958A5465B65FFA86F7CD38332ABF8EDF19CD8015215A9BE2AA3DBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344FDECC3B9E4D57D45754AFBB18D42CB3C64D6F9555CB442F58D7AEFCE205655A27B129C14BA2B5A11D7E09C32AA3244CA20F646061FC2244D36BB6C435184A638A6D4CC6FBFAC251729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPL6H901iH3HZpxthXpUNZg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D24F27A2EEF7469DD7F6752A3588993AB83D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 06/21] sql: refactor RANDOM() function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! I added a description to the function. On Fri, Oct 08, 2021 at 08:31:43PM +0300, Mergen Imeev via Tarantool-patches wrote: Diff: diff --git a/src/box/sql/func.c b/src/box/sql/func.c index 33436da26..b612c6b62 100644 --- a/src/box/sql/func.c +++ b/src/box/sql/func.c @@ -871,7 +871,11 @@ func_printf(struct sql_context *ctx, int argc, struct Mem *argv) mem_set_str_allocated(ctx->pOut, sqlStrAccumFinish(&acc), acc.nChar); } -/** Implementation of the RANDOM() function. */ +/** + * Implementation of the RANDOM() function. + * + * This function returns a random INT64 value. + */ static void func_random(struct sql_context *ctx, int argc, struct Mem *argv) {