From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4E4166EC57; Fri, 15 Oct 2021 00:56:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E4166EC57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1634248589; bh=IeP2kySarJ9jNkF4+4wdjAOvTa7iJDmacPouFz1TR3k=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=hBdwFPp+cI2sG7slt0ZUnCEybeEvDGQXDg5V1Z4Wic6CGBrhFBDwIgXUGzkIlnEc5 a6fsZvakrEt6HdaxaIdX69d5+RPjBlxk2o5+Mhu7oaTJMqqiVBnu0yA4KOp88u02c4 JEnvQylwEk78Af6W6J5SPTyUjjrBYV5Us7+j+G8s= Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A42D86EC57 for ; Fri, 15 Oct 2021 00:56:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A42D86EC57 Received: by mail-lf1-f46.google.com with SMTP id p16so33156116lfa.2 for ; Thu, 14 Oct 2021 14:56:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/4az8v1mcCAgY3IrRQUlSTK/6LEU0g74JOsh3UBjjG8=; b=a2dPS6ZOBWBcGd/RKBcPH4/WRWrLG+FJD0lb+Yoz9dlR9bUcKkDf7OuU/adFW6Oq1g ynY0DX6fXXYmrxQZQN5J0ApuyR7T3Fo/Y8bGcBPZfyGJTMYo5zG4gSSWKozD8Qy6bGIj 7hKX8nAzI3zSU+UNL+KGxnXOWn0bbucg9l2cjbZPJU7NLXjf9JUz93BU9axh4yByCQ9P YxHK1NGdqsGWOrZYRCKTlSa0/yAXQiWrJO0+wKAinWskhJ3f8q6zVxUDr3U5mznVBYvI lQkBsxTDeLZFJATCZH/PN195xfdtqs5Klbb/lSVv72wrSarofn9zwmjEpAxs5nMm7g5k E6EA== X-Gm-Message-State: AOAM532f+QZGvGsDbSvWAZQC5SwghYa1kw6FHuFg19kvF0c+HR4GsPue 3LBIzmWOskJF2teapYeQNIthbB5Y3Jg= X-Google-Smtp-Source: ABdhPJzIaCJRacuuMgiWPBZtpXN6qaXm0D/vBVHWrPbxkz4TJAKEN2NhcZATCC9ZqWuTfCSXkUVCbg== X-Received: by 2002:a05:6512:1042:: with SMTP id c2mr7160709lfb.223.1634248585432; Thu, 14 Oct 2021 14:56:25 -0700 (PDT) Received: from grain.localdomain ([5.18.253.97]) by smtp.gmail.com with ESMTPSA id x2sm327240lfr.307.2021.10.14.14.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 14:56:24 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id B67F45A0020; Fri, 15 Oct 2021 00:56:23 +0300 (MSK) To: tml Date: Fri, 15 Oct 2021 00:56:19 +0300 Message-Id: <20211014215622.49732-1-gorcunov@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v23 0/3] qsync: implement packet filtering (part 1) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Guys, please take a look once time permit, any comments are highly appreciated! Serge, here are some important changes: - as being discussed verbally about limbo owner test I think most straight forward solution is to allow nesting txn_limbo_is_owner calls - in test I left the snippet | -- Finally enable election_replica3 back. Make sure the data from new election_replica2 | -- leader get writing while old leader's data ignored. | test_run:switch("election_replica3") | box.error.injection.set('ERRINJ_WAL_DELAY', false) | test_run:wait_cond(function() return box.space.test:get{2} ~= nil end) | box.space.test:select{} untouched because final select{} does test for needed results so I don't need to count writes The tests are passed locally but lets wait for complete CI results. v22 (by SergeP): - use limbo emptiness test _after_ owner_id test - drop redundant assert in limbo commit/rollback since we're unlocking a latch anyway where own assertion present - in test: drop excessive wait_cond and setup wal delay earlier v23 (by SergeP): - fix problem with owner test in case of recovery journal - update test branch gorcunov/gh-6036-rollback-confirm-23 issue https://github.com/tarantool/tarantool/issues/6036 previous series https://lists.tarantool.org/tarantool-patches/20211011191635.573685-1-gorcunov@gmail.com/ Cyrill Gorcunov (3): latch: add latch_is_locked helper qsync: order access to the limbo terms test: add gh-6036-qsync-order test src/box/applier.cc | 12 +- src/box/box.cc | 15 +- src/box/relay.cc | 11 +- src/box/txn.c | 2 +- src/box/txn_limbo.c | 49 ++++- src/box/txn_limbo.h | 87 +++++++- src/lib/core/latch.h | 11 + test/replication/gh-6036-qsync-order.result | 190 ++++++++++++++++++ test/replication/gh-6036-qsync-order.test.lua | 93 +++++++++ test/replication/suite.cfg | 1 + test/replication/suite.ini | 2 +- test/unit/snap_quorum_delay.cc | 5 +- 12 files changed, 447 insertions(+), 31 deletions(-) create mode 100644 test/replication/gh-6036-qsync-order.result create mode 100644 test/replication/gh-6036-qsync-order.test.lua base-commit: 4bca48611d7ae772ea095181349194c0c31f9a9b -- 2.31.1