From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C896E6FF9F; Tue, 5 Oct 2021 13:07:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C896E6FF9F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1633428466; bh=O7kBxfGnEFmFoMnWQSB6WAsnHTWbXErrrX5FLqaia8I=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fp12Yrslj+p4ZFH7kG3dVy/ugB3oP3oroD2wHTZUsYI3QEswdmUsQyrg1tcDIp3fa dkgemrXcLjb2ibXOwrFKl0HZAPjzlndMwki+au4fm5j4S9KWRnymBBTclVrQiOJO0f 7jOhDJeTCgQQqJ7yOECpcQXDcIfmsSAQDEAbCZLY= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 801826FF9F for ; Tue, 5 Oct 2021 13:07:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 801826FF9F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mXhMN-0005x6-Kt; Tue, 05 Oct 2021 13:07:45 +0300 Date: Tue, 5 Oct 2021 13:07:42 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20211005100742.GG55311@tarantool.org> References: <440e898334cae0debebd83d8cde70bbda150f2e9.1633092363.git.imeevma@gmail.com> <445b19bf-c2b4-b243-22cc-ed9eebb0a464@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <445b19bf-c2b4-b243-22cc-ed9eebb0a464@tarantool.org> X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE93F36DF21ED6F8B2DA80A943982704D27182A05F5380850407FF8D985B057DF0E2FB0971D2372FBD5DE0D55A4FA1182E758C9F6AB9C81EA85 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E347E1311495C1B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D889009C159F637B20F37BC689DDB0E238117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5054B1D3D3962F1904389DA5E5B1ADAEF6C X-C1DE0DAB: 0D63561A33F958A5E1E947D5C82A388EBD33E07BD6CDA702B628B167E3E756D2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75C4D20244F7083972410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34023CA4E4726A7D6C2A6312B067B0AF940C1BB378362BB37A55D2308CA3873FB0E1437F6E8187F50A1D7E09C32AA3244CA84DB00B5CE50DB5FC0F794374DD5D3CBBA718C7E6A9E042729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhAh8SZXECpD7qPi8SbGusg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D6763B1EE3B4517AC1EF211A904B3BAD883D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 12/16] sql: refactor MIN() and MAX() functions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! My asnwer below. On Mon, Oct 04, 2021 at 11:54:10PM +0200, Vladislav Shpilevoy wrote: > Good job on the fixes! > > > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > > index a3d403176..96eb76244 100644 > > --- a/src/box/sql/vdbe.c > > +++ b/src/box/sql/vdbe.c > > @@ -4161,7 +4161,6 @@ case OP_AggStep: { > > } > > #endif > > > > - pMem->n++; > > Could you please remind me why is it dropped in this commit? I dropped this because it affects the result of the MIN()/MAX() functions. Prior to this patch-set, each aggregate MEM contained one special structure. They each have a constant size, so mem->n could have been and was used for something else. However, I have no idea why it was here or what it was used for.