From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ECE266EC57; Mon, 4 Oct 2021 16:32:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECE266EC57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1633354362; bh=HSu/WnfiJTQp9ZToD9qNqQD9f+BjttOJ2kG1gc17X6I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VRhIq8UWuYt2GIS4yx+Z2m1eXfEibSs9hJ81DySfMa3e2DjWIsgy9Ec98kffFgufn 66EwLczOEi2CKAO0wXinQ65hKGwRRwQhVwMu1LvVieZWUMlpQRQPsqCm2ZN4w6Dqvh Ki1ZdrcyV7pq1PxvB9iTrve3BRgScF5VHSBnlSEM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D74216EC56 for ; Mon, 4 Oct 2021 16:32:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D74216EC56 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mXO59-0005Jq-Al; Mon, 04 Oct 2021 16:32:39 +0300 Date: Mon, 4 Oct 2021 16:32:38 +0300 To: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20211004133238.GA154920@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96A58C36AA2E996499DED20B83AFF2DE90C450EFC080BE8B7182A05F53808504062C28A1CF5076C7F8E073D6543D7859A63014728899C218F55F80919CA181DD4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9D6DADD6B53929DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D54B99ECAFA2F678638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CAC94F7D7689BAC0B497BAEF720D54F7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A504FBDC9CF88AA3FC045FAE5C8B1F29FF8384AE32E321BC24D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75B7BFB303F1C7DB4D8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D041FB2E16F174C4DC5E9BE1A010C3C86D3203C31B4BB69EFB734DD3FEC345314E765CBB21B8B6F41D7E09C32AA3244C46DC31527D1AD2C31DA27641DF76A20A250262A5EE9971B0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+1ww+tpaZeqIAVGojDn4jA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DC274F605D10CAD9AB9978CE7DF7B154C83D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 0/8] Rework standard function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! I'm sorry, I forgot to add links to the issue and the branch. Here they are: https://github.com/tarantool/tarantool/issues/4145 https://github.com/tarantool/tarantool/tree/imeevma/gh-4145-rework-sql-built-in-funcs On Fri, Oct 01, 2021 at 07:29:23PM +0300, Mergen Imeev via Tarantool-patches wrote: > This patch refactors all non-aggregate standard functions and makes these > functions work according to ANSI rules, if it is possible. However, the ANSI > specific syntax for these functions will be presented later. > > Mergen Imeev (8): > sql: refactor ABS() funcion > sql: refactor CHAR_LENGTH() function > sql: refactor UPPER() and LOWER() functions > sql: refactor NULLIF() function > sql: rework TRIM() function > sql: rework POSITION() function > sql: rework SUBSTR() function > sql: refactor LIKE() function > > src/box/sql/func.c | 1137 +++++++++++++++----------------- > test/sql-tap/badutf1.test.lua | 41 +- > test/sql-tap/func.test.lua | 16 +- > test/sql-tap/func2.test.lua | 150 ++--- > test/sql-tap/position.test.lua | 80 ++- > test/sql-tap/substr.test.lua | 121 +++- > 6 files changed, 786 insertions(+), 759 deletions(-) > > -- > 2.25.1 >