From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 967CA6FC87; Wed, 29 Sep 2021 09:32:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 967CA6FC87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632897131; bh=kbB8VZMkg4ACVoqenw35Kss+NP6q+giTycMHTy9uJgE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aWzu4UcHyXAud3l8kxTW48nGU5iwAjq87KXx9dT8imFf6Q7szXsCiL3xk9wQ0R+VA ZrlVduTse/CaL8HXuR1hv4UMCBDoweEXX+ncfRx3Q/Ov6PxzmFhWwqe5bATXY1d4O2 eU2oIUh65lAeXDRtHP728y/guVJWKbfbDcNajvrM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DFCF36FC87 for ; Wed, 29 Sep 2021 09:32:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DFCF36FC87 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mVT8S-0000Nb-Li; Wed, 29 Sep 2021 09:32:09 +0300 Date: Wed, 29 Sep 2021 09:32:07 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210929063207.GA49817@tarantool.org> References: <38ac1b8d1ecae3352b8fe748def9e8a451239b9a.1630915850.git.imeevma@gmail.com> <4e091d79-84c5-9ba1-f624-185cfced6591@tarantool.org> <20210909110754.GA51222@tarantool.org> <6849d9f6-c34b-db33-ee64-a20f9201b01d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD96A58C36AA2E996499DED20B83AFF2DE90C450EFC080BE8B7182A05F538085040FEB1423184D44750B96160D00BAFFF849E1501238844F31DC0B34082655F134D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7811C3E343B302E2EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063706922F90966A37BA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D826837D48207988F400D38B9F65626E5E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5FC2223BDC1606AF84F81630F32000F6D161E6A9D86ABCDB8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75BFC02AB3DF06BA5A410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348D68DCC07DD06FF562BD420F45AC1EF4C5DC05D9E61D34AFECF393E765E98F833079E4E06089FE561D7E09C32AA3244C4E87B6A67F4A0A6F0D21C70201D7794539C99C45E8D137E9729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWaDhU1ub98ZO+Q420qoeIQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DA4B6BFD6D4CE6DD0C26E41A6FDE1F72883D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] schema: remove assert on wrong insert into _priv X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! I'm very sorry! I rebased and pushed: https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id On Tue, Sep 28, 2021 at 12:33:02AM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the fixes! > > On 27.09.2021 08:41, Mergen Imeev wrote: > > Hi! > > > > On 09.09.2021 14:07, Mergen Imeev wrote: > >> Hi! Thank you for the review! My answers, diff and new patch below. > >> > >> On Tue, Sep 07, 2021 at 11:59:58PM +0200, Vladislav Shpilevoy wrote: > >>> Hi! Thanks for the patch! > >>> > >>> See 4 comments below. > >>> > >>> On 06.09.2021 10:11, imeevma@tarantool.org wrote: > >>>> Prior to this patch, an assertion was throwed if a tuple with an > >>> 1. throwed -> thrown. > >>> > >> Fixed. > > I still see it on the branch. > > >>>> incorrect id was inserted into the _priv system space. This bug > >>>> appeared only in the debug build. > >>>> > >>>> Closes #6295 > >>>> --- > >>>> https://github.com/tarantool/tarantool/issues/6295 > >>>> https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id > >>> 2. Could you please add a changelog? > >>> > >> Added. > > Not on the branch. > > Are you sure you pushed the new version?