Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org,
	skaplun@tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] test: adapt tests checking loading bytecode files
Date: Fri, 24 Sep 2021 17:28:57 +0300	[thread overview]
Message-ID: <20210924142857.66614-1-m.kokryashkin@tarantool.org> (raw)

Loading bytecode with an extra header (BOM or "#") is disabled
for security reasons since LuaJIT-2.0.0-beta10.
For more information see comment for `lj_lex_setup()` in <src/lj_lex.c>.
Also see commit 53a285c ('Disable
loading bytecode with an extra header (BOM or #!).').
Tests are adapted to LuaJIT behavior.

Closes tarantool/tarantool#5691
Part of tarantool/tarantool#5845
Part of tarantool/tarantool#4473
---
Issue: https://github.com/tarantool/tarantool/issues/5691
Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5691-adapt-bytecode-PUC-Rio

 test/PUC-Rio-Lua-5.1-tests/main.lua | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/test/PUC-Rio-Lua-5.1-tests/main.lua b/test/PUC-Rio-Lua-5.1-tests/main.lua
index 07facc4c..c62950c8 100644
--- a/test/PUC-Rio-Lua-5.1-tests/main.lua
+++ b/test/PUC-Rio-Lua-5.1-tests/main.lua
@@ -172,23 +172,17 @@ prepfile(s)
 prepfile[[#comment in 1st line without \n at the end]]
 RUN("lua %s", prog)
 
--- FIXME: Loading bytecode with an extra header (BOM or "#")
+-- Loading bytecode with an extra header (BOM or "#")
 -- is disabled for security reasons since LuaJIT-2.0.0-beta10.
 -- For more information see comment for `lj_lex_setup()`
 -- in <src/lj_lex.c>.
 -- Also see commit 53a285c0c3544ff5dea7c67b741c3c2d06d22b47
 -- (Disable loading bytecode with an extra header (BOM or #!).).
 -- See also https://github.com/tarantool/tarantool/issues/5691.
--- The test is disabled for LuaJIT.
-prepfile("#comment with a binary file\n"..string.dump(loadstring("print(1)")))
--- RUN("lua %s > %s", prog, out)
--- checkout("1\n")
-
-prepfile("#comment with a binary file\r\n"..string.dump(loadstring("print(1)")))
--- FIXME: Behavior is different for LuaJIT. See the comment above.
--- The test is disabled for LuaJIT.
--- RUN("lua %s > %s", prog, out)
--- checkout("1\n")
+-- The test is adapted to LuaJIT behavior.
+prepfile(string.dump(loadstring("print(1)")))
+RUN("lua %s > %s", prog, out)
+checkout("1\n")
 
 -- close Lua with an open file
 prepfile(string.format([[io.output(%q); io.write('alo')]], out))
-- 
2.33.0


             reply	other threads:[~2021-09-24 14:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24 14:28 Maxim Kokryashkin via Tarantool-patches [this message]
2021-10-11 14:25 ` Sergey Kaplun via Tarantool-patches
2021-10-11 20:02   ` Максим Корякшин via Tarantool-patches
2021-10-12  8:13     ` Sergey Kaplun via Tarantool-patches
2022-02-16 12:43       ` Igor Munkin via Tarantool-patches
2022-02-17  8:57         ` Maxim Kokryashkin via Tarantool-patches
2022-02-17  9:51         ` Sergey Kaplun via Tarantool-patches
2022-02-16 12:43     ` Igor Munkin via Tarantool-patches
2022-02-17 16:38 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924142857.66614-1-m.kokryashkin@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking loading bytecode files' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox