From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0EF856EC40; Tue, 21 Sep 2021 13:49:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0EF856EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632221384; bh=hjftDZ9GyH5xL2bCnBy7LFbz76Gy+KHWr5NTj8CXwF4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=khalAROgrl5mmMiZ3S+QUliIYkOxGBB8GcUaDZCMY1MXDSn0+edciza5xZXLtvtEh My5QRqvpgNQIOhgtnSXdWsBo7RfpvNfgs9mUDIhD4xvxk3lwZwZY5epgZFAgcSC0z2 cP7pfmVuJuHvWwiiYtXGIAwlCuL0xrlwu+atCWi0= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D49366EC40 for ; Tue, 21 Sep 2021 13:49:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D49366EC40 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mSdLJ-0006WB-6J; Tue, 21 Sep 2021 13:49:41 +0300 Date: Tue, 21 Sep 2021 13:49:40 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210921104940.GC16139@tarantool.org> References: <3023d600fc46ecd6158c4a28914576a9c2ccad2d.1631289462.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2FBA0FFC16CEFBFC694531AE86BFF036DF00894C459B0CD1B9D4167A3443853A8E831A767471F148AA994D8960CDEEF0A8153706201BB5503E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D3BE5B596754B8C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7A3295C83650092F9EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F240C632B4178163086F181D5B65D6DE10CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC878444BBB7636F62AF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B953A8A48A05D51F175ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5E8B810B7C45363D2CCACCB59B1B1B58132937DA9BC051E3CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75691C03A47F1B0C416D6546786ADF492D5A0AA20F8A0307212E763F503762DF505E4DBAB5AF249FA793EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3429538671E6527D32499F9B3CC8A85CF4A2EB140F857DCC40D99A39E2F6EEE552E07CB73D172B541B1D7E09C32AA3244C27B42CBE37D590832C547FB9D3A4FB3EB4DF56057A86259F729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnvI84oHUDXD6lKiIsHWzsA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D337372A4FE1DB0194C6B6B0A38EF657383D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 12/13] sql: remove copying of result in finalizers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! On Tue, Sep 14, 2021 at 11:24:18PM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > Shouldn't you also delete the sizeof(Mem) from the context size > in sql_context_new()? No, but I will change from sizeof(struct Mem) to sizeof(struct Mem *). Also, I will completely drop argv from struct sql_context in the new patch.