From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 138E56FC86; Thu, 16 Sep 2021 18:56:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 138E56FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631807780; bh=EoLNnrKYhGWDcdp/xOuHMugaWSNRFC5U5gqwQwwIfV4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ar4Bkt1tv22QGsDgqZ3HN1jx1jzmquTLe1n76WqmqrpVuG7jHBfNLFKWXwkc++f6N o00nQa83OEWqjEnUn5JsrJxaIIgI8SATppDasH09FvHw8Ux/hVUO/qd+t1/b7r/jo0 +hsGE4DNcEBBt3BZ3WklxhU8y0tr/IPSuSkzSD08= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0849C6FC86 for ; Thu, 16 Sep 2021 18:56:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0849C6FC86 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mQtk0-00045O-Sg; Thu, 16 Sep 2021 18:56:01 +0300 Date: Thu, 16 Sep 2021 18:29:47 +0300 To: Mikhail Shishatskiy Message-ID: <20210916152947.GB6844@tarantool.org> References: <20210820070546.115293-1-m.shishatskiy@tarantool.org> <20210820070546.115293-3-m.shishatskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210820070546.115293-3-m.shishatskiy@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2FECE56E2A292C9F7D3C69CC5C84EEB3A800894C459B0CD1B931ECBD480DA7393CBAE392C4CCA0CF192865F1F1D023BD9575832A37A19CB0B4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A548C5E803E75135EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637835928C62272F24E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8371593FC119A424533E8060B0AA1934F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67ECBC18655D52CDF089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5055428A3E17DA3992983236D93F8F45491 X-C1DE0DAB: 0D63561A33F958A5EA6C34529C32900CC98BB4B436D875F8BD657066E8A13EFBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7540E9CF2C1C1CEBBA410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A08F09726D78E07BFC987DDA3E8D9ADE8B757C088FA37DB8B788389F6C542C0191553F6D55C0C0E31D7E09C32AA3244C3BECFEA3AB8EE824A4F8B3BE235C9E597C0C08F7987826B9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbgLrBZmQxDToDvJXqyHsrg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D29A5CE1291BF61CB1BE5D9B311FC6679A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/5] test: separate memprof Lua API tests into subtests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Misha, Thanks for the patch! LGTM, with few ignorable nits below. On 20.08.21, Mikhail Shishatskiy wrote: > As the number of memprof test cases is expected to grow, > memprof tests are separated into subtests to encapsulate > test cases and be able to skip some of the subtests. > > Part of tarantool/tarantool#5814 > --- > > Issue: https://github.com/tarantool/tarantool/issues/5814 > Luajit branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number > tarantool branch: https://github.com/tarantool/tarantool/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number > > .../misclib-memprof-lapi.test.lua | 153 ++++++++++-------- > 1 file changed, 83 insertions(+), 70 deletions(-) > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index 06d96b3b..dbf384ed 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > +-- Test profiler API. > +test:test("base", function(subtest) Minor: The popular name for this is not "base", but "smoke". Basic test should also validate the output, but the smoke one can just check that everything looks or seems to be OK. Anyway, feel free to ignore. > + subtest:plan(6) > > + -- Check allocation reports. The second argument is a line number Typo: Comment exceeds 66 symbols (however, I'm not sure this is still required in our guidelines; if it's not, then feel free to ignore). > + -- of the allocation event itself. The third is a line number of > + -- the corresponding function definition. The last one is > + -- the number of allocations. > + -- We need to cause stack resize for local variables at function > + -- call. Let's create a new coroutine (all slots are free). > + -- It has 1 slot for dummy frame + 39 free slots + 5 extra slots > + -- (so-called red zone) + 2 * LJ_FR2 slots. So 50 local variables Typo: Comment exceeds 66 symbols (however, I'm not sure this is still required in our guidelines; if it's not, then feel free to ignore). > + -- is enough. > -- > 2.32.0 > -- Best regards, IM