From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: Throw an error when getting an unknown MP_EXT
Date: Fri, 27 Aug 2021 12:30:33 +0000 [thread overview]
Message-ID: <20210827123033.6evhcq3cyrasomye@tarantool.org> (raw)
In-Reply-To: <97b34dbbaf797bfe417c7317e3cb1ec244701d6e.1629975948.git.imeevma@gmail.com>
Hello,
On 26 авг 14:07, Mergen Imeev via Tarantool-patches wrote:
> After this patch, getting an unknown msgpack extension in SQL will throw
> the correct error.
>
> Closes #6375
> ---
> https://github.com/tarantool/tarantool/issues/6375
> https://github.com/tarantool/tarantool/tree/imeevma/gh-6375-assert-on-getting-unknown-mp-ext
LGTM.
I've checked your patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2021-08-27 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 11:07 Mergen Imeev via Tarantool-patches
2021-08-26 20:11 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-27 12:30 ` Kirill Yukhin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210827123033.6evhcq3cyrasomye@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: Throw an error when getting an unknown MP_EXT' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox