From: Vladimir Davydov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] net.box: add __serialize and __tostring methods for future objects
Date: Thu, 26 Aug 2021 18:05:06 +0300 [thread overview]
Message-ID: <20210826150506.awix2cx2n2i22zj3@esperanza> (raw)
In-Reply-To: <CAK0MaD0BoUdfP4Eg4rcmWOin-Kv7-=LHTq39+QPDDbFQAWiKoQ@mail.gmail.com>
On Thu, Aug 26, 2021 at 05:56:46PM +0300, Yaroslav Dynnikov wrote:
> While reviewing it, I've noticed that the autocompletion doesn't work
> for a net.box.future object. I guess it's a topic for another issue,
> isn't it? Besides that, LGTM.
I'm not sure, we can possibly make autocompletion work with __index,
but yes, it's a different issue.
Pushed to master.
prev parent reply other threads:[~2021-08-26 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 12:58 [Tarantool-patches] [PATCH] " Vladimir Davydov via Tarantool-patches
2021-08-13 17:41 ` Yaroslav Dynnikov via Tarantool-patches
2021-08-17 7:58 ` Vladimir Davydov via Tarantool-patches
2021-08-17 8:00 ` [Tarantool-patches] [PATCH v2] " Vladimir Davydov via Tarantool-patches
2021-08-24 22:39 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-25 13:35 ` Vladimir Davydov via Tarantool-patches
2021-08-25 20:08 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-26 14:56 ` Yaroslav Dynnikov via Tarantool-patches
2021-08-26 15:05 ` Vladimir Davydov via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826150506.awix2cx2n2i22zj3@esperanza \
--to=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] net.box: add __serialize and __tostring methods for future objects' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox