From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 568C76EC40; Thu, 19 Aug 2021 15:26:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 568C76EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629376005; bh=YpVH9+Al3ql9Z4oDk75eQt+YVpNLuLOkbkBUp2PMebI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r/MZW0t4+/EQU8i6jxbi/2ODFWnNIBqkuuSNjo91FIcKgDJagPuatHK2MdSMawZKC MjlW2Um61CkHC9V91i+CPgmW4sUyEoMRPMKJPXkfKonabmHXb9FJd/pVjmLlFJRW4V 9BMDbA3zeCuLTsLeJw7DqmYGjImOYYMKsMDb6NhI= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 446646EC40 for ; Thu, 19 Aug 2021 15:26:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 446646EC40 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1mGh86-0002XW-CP; Thu, 19 Aug 2021 15:26:42 +0300 Date: Thu, 19 Aug 2021 12:26:42 +0000 To: imeevma@tarantool.org Message-ID: <20210819122642.b5pvtli465gse5l2@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD91BCCB18F2C129F87F36E61E9E4584E9D182A05F5380850402759F3F2481AE9E8E0FA29239506DCA534B353D309B7AB5C4880F61A5731FE71 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7548C33FFD72831AFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B05885A782BE20C5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2508E1F0197B6983357C306732C575FEDCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063768889A976CB567F3D81D268191BDAD3DBD4B6F7A4D31EC0BEA7A3FFF5B025636D81D268191BDAD3D78DA827A17800CE751594ACE58E568BCEC76A7562686271EEC990983EF5C03292E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C34B08FA16E56A400835872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D0B18DC6AC13D9A1C8DC56E514619D676 X-C1DE0DAB: 0D63561A33F958A55A8593C00D3EF5412CAEB9A870519CA383B901541632C217D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758B25CD4253D1D611410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FD9114F69CA58D1ED5F8EF6096554D7633CCE5DE8CA7B5DA06947A43483DC8B7E1CD112EB02E462A1D7E09C32AA3244C189280D2B63A729EF4FB010B9BE17E0D51E887DA02A9F7BFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSxK+6r6oBEhwy1i52DqDA== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2CA6F151BC02A2332F49B7CFEF6754FFFD3DD8D7677BAA3E4CA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 19 авг 15:02, imeevma@tarantool.org wrote: > This patch introduces static and dynamic type checks for SQL built-in functions. > > https://github.com/tarantool/tarantool/issues/6105 > https://github.com/tarantool/tarantool/tree/imeevma/gh-6105-properly-check-funcs-args-types > > Mergen Imeev (9): > sql: modify signature of TRIM() > sql: rework SQL built-in functions hash table > sql: check number of arguments during parsing > sql: static type check for SQL built-in functions > sql: runtime type check for SQL built-in functions > sql: enable types checking for some functions > sql: fix result type of min() and max() functions > sql: check argument types of sum(), avg(), total() > sql: arguments check for string value functions LGTM. -- Regards, Kirill Yukhin