From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 81DD56EC40; Thu, 19 Aug 2021 10:33:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 81DD56EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629358415; bh=9NK/lmFVUMaL2UHTizLiFbdbtCnM4fZGpf8gyDm6SXY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Wa3WYfRYJecirGhDEZMqDTMpuyLR7+lQwvKdyXOEylLsFUg3rdkVdR6/mHXpJZPCu YG2C+Xh1tOctEaC7mnFd0kddl9/ysWbip4Fe+oZSDzwUL8F/uS4wKrUKS1JM+2tuUI l4GoZT1A6K0pJnO9NTrxJ/joC1TAl8oUl6k7jtqg= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 225966EC40 for ; Thu, 19 Aug 2021 10:33:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 225966EC40 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1mGcYP-00037H-2h; Thu, 19 Aug 2021 10:33:33 +0300 Date: Thu, 19 Aug 2021 07:33:32 +0000 To: Igor Munkin Message-ID: <20210819073332.w2qdsgoti5kq4krm@tarantool.org> References: <3c9433a3166bcc2396efb01e89261dea370bd5c1.1629315033.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3c9433a3166bcc2396efb01e89261dea370bd5c1.1629315033.git.imun@tarantool.org> User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD91BCCB18F2C129F87F36E61E9E4584E9D182A05F5380850400CEB288DFCF551FB51DC6C8433362C8E3A798C471E3C802D6A4E7A6380FE8BE2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F6EE1C40B2E8BE15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377BA6DB23C50317A38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86F4A4502188CF0888426F6069F1564D4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FECEDA8D6C8C3B0531D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3457EE4B4996FC54603F1AB874ED89028C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D0B18DC6AC13D9A1C4D4A75BC5014871E X-C1DE0DAB: 0D63561A33F958A5E6197C6FB3B0AB0C385CDE95DC9443A1CCCF2C129A42529BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758B25CD4253D1D611410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A58BF0C7EAC340F06DB659E1F2E78808223E3FA27FA3ABE2FE60C0C894DB15F97FFBBF67EDBF3071D7E09C32AA3244CDD284BDD801FB4CBE5D518DB9651B01BC86C126E7119A0FEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSxK+6r6oBFM7k37b8Evog== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD21C640DEDDE06CE1BC3E8BFBA497AEB27A3C9BEA1551410FCCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix exit stub patching. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 18 авг 22:51, Igor Munkin wrote: > From: Mike Pall > > Contributed by Javier Guerra Giraldez. > > (cherry picked from commit 9da06535092d6d9dec442641a26c64bce5574322) > > When the side trace is assembled, it is linked to its parent trace. For > this purpose, JIT runs through the parent trace mcode and updates jump > instruction targeted to the corresponding exitno. Prior to this patch, > these instructions were patched unconditionally, that leads to errors if > the jump target address is out of the value ranges specified in ARM64 > references[1][2][3][4][5][6]. > > As a result of the patch considers value ranges of > the jump targets and updates directly only those instructions fitting > the particular jump range. Moreover, the corresponding jump in the pad > leading to is also patched, so those instructions, > that are not updated before, targets to the linked side trace too. > > Additionaly, there is some refactoring of jump targets assembling in > scope of this patch. > > Igor Munkin: > * added the description and the test for the problem > > [1]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/B > [2]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/B-cond > [3]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/CBZ > [4]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/CBNZ > [5]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/TBZ > [6]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/TBNZ > > Resoves tarantool/tarantool#6098 > Part of tarantool/tarantool#5629 LGTM. -- Regards, Kirill Yukhin