Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] core: fix cur_L restoration on error throw
Date: Wed, 18 Aug 2021 23:26:56 +0300	[thread overview]
Message-ID: <20210818202655.GI5743@tarantool.org> (raw)
In-Reply-To: <YR1niHeaFiRm06JB@root>

Sergey,

Thanks for the fixes! See both odroid CI pipelines successfully
finished, gratz!

On 18.08.21, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review!
> 
> On 18.08.21, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! I'm very curious what's wrong with FreeBSD... The
> > first version is more portable, but since we're going to revert this
> > commit few patches later, I'm open to any implementation.
> > 
> > LGTM, with some nits.
> > 

<snipped>

> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM

  reply	other threads:[~2021-08-18 20:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 10:19 [Tarantool-patches] [PATCH luajit] " Sergey Kaplun via Tarantool-patches
2021-08-18  8:49 ` [Tarantool-patches] [PATCH luajit v2] " Sergey Kaplun via Tarantool-patches
2021-08-18 16:57   ` Igor Munkin via Tarantool-patches
2021-08-18 20:03     ` Sergey Kaplun via Tarantool-patches
2021-08-18 20:26       ` Igor Munkin via Tarantool-patches [this message]
2021-08-19  8:23   ` Igor Munkin via Tarantool-patches
2021-08-19  7:42 ` [Tarantool-patches] [PATCH luajit] " Kirill Yukhin via Tarantool-patches
2021-08-19  7:56   ` Vitaliia Ioffe via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818202655.GI5743@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2] core: fix cur_L restoration on error throw' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox