From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AC8E46EC40; Tue, 17 Aug 2021 22:13:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC8E46EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629227619; bh=EMD8lZIzV70eVf5t7CB0ih3Y0kE5e8SMjzEZE+dmwmE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BODLGHtsYm2KODRmew9FFgFHkGR+7TByAmrUOCUCs8DqcVsrrCVnPmcvpWms90tSc jqvWZy4ome4tUufsjGssLRIGcSPEr09qljjO2RuYjc+Uanm6SASRVdNh38CyXNa7Vm 3oTrR9B9jZQaivkJkTIDIGwmft9/98LEvfRjRYKw= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A4F16EC40 for ; Tue, 17 Aug 2021 22:13:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A4F16EC40 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1mG4Wn-0003Qt-HM; Tue, 17 Aug 2021 22:13:37 +0300 Date: Tue, 17 Aug 2021 22:13:35 +0300 To: Timur Safin via Tarantool-patches Message-ID: <20210817191335.oczb7e7w7tlcnu2w@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD910164DC12A5633065676A9727AC27C74182A05F538085040F66EDAEC66FBCEA9DE9F7CAB98B299EDCE498C3CED90B6262F945F62068C9087 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D8F5094E9BAC3E9F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8326B93531DA13DDBF499CB4633EA6D0B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520140C956E756FBB7AF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C797D05A5B68411496E0066C2D8992A164AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3FF7BA3E59F6694FABA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74ABCC139FF3F849B731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D0B18DC6AC13D9A1C0FD6D9E047D8E31E X-C1DE0DAB: 0D63561A33F958A506C5E323B3786B94BFF824176C159F1BD808340956FC35BAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA757E10A58996CBD514410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E229BE567979C9408C1B2157AC7050E07D663214514D34685562F0BF5DA747D9E2A7230BDEBFCA3D1D7E09C32AA3244C0981E56BC7BF480FCC5710F8745917E3853296C06374E60283B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojuRQ/H5n28tpV0n+sbZjKfQ== X-Mailru-Sender: EAC3DA4C40F0802FC8DB1BBF04B7D9F2F90462BE97DD3BE9438576C80837833DC024C8EB21122C10F0798C444D2DF93A342CD0BA774DB6A9B195EA2AC6D0D44E902A426E4A0C259E9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 7/8] datetime: perf test for datetime parser X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladimir Davydov via Tarantool-patches Reply-To: Vladimir Davydov Cc: v.shpilevoy@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, Aug 16, 2021 at 02:59:41AM +0300, Timur Safin via Tarantool-patches wrote: > It was told that if field `datetime.secs` would be `double` we should get > better performance in LuaJIT instead of `uint64_t` type, which is used at the > moment. > > So we have created benchmark, which was comparing implementations of functions > from `datetime.c` if we would use `double` or `int64_t` for `datetime.secs` field. > > Despite expectations, based on prior experience with floaing-point on x86 > processors, comparison shows that `double` provides similar or > sometimes better timings. And picture stays consistent be it SSE2, AVX1 or > AVX2 code. > > Part of #5941 I don't think this belongs in the repository. My understanding of the perf tests committed to the repository (may be wrong) is that they are supposed to be used to ensure there's no performance degradation of a certain subsystem. Ideally, they should be run automatically after each commit. The test added by this patch just checks what implementation of datetime is faster - with double or int64_t.