From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 70AB86EC40; Tue, 17 Aug 2021 11:12:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 70AB86EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629187974; bh=mS8aWLickZv80DP+hz8qVmnBMArYR6iR1fS8nhboSFY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ShmEkqjMAw7wmMdq/cc0oj5OrWLPCux65vGFr3UUnAV85m5vnsIuZDIYwahJwMvlL AKfLzty4FGuGOhm0NObiNG18bV/7Z8ozccnfgSHxMzFC99PDKpJVMSCf4hPzXOshvD PWhreAu2PNbOruHBoJ/NLgjK/Nqqaum1kP1na+kM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 855DC6EC40 for ; Tue, 17 Aug 2021 11:12:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 855DC6EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mFuDL-000447-J7; Tue, 17 Aug 2021 11:12:52 +0300 Date: Tue, 17 Aug 2021 10:47:41 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: <20210817074741.GB5743@tarantool.org> References: <1628864967.181226130@f723.i.mail.ru> <20210814113834.1171307-1-m.kokryashkin@tarantool.org> <20210816084902.GS27855@tarantool.org> <1629108103.120226674@f190.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1629108103.120226674@f190.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9F9A2272A1D086A28553D1D5C4B4124EF182A05F538085040B7B73D1273173C4DD9A96012BC1A317EF782AD211366EA1FFF512C3AB8B3406A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E5D7EAC6EBA58433EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637539FDAA91738A5BD8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80DAE095FFF2C2146FD5170932031FF3A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC47272755C61AA17BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520140C956E756FBB7AE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BF3059D42242344A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53BA84B4172E6F1D0B844F3C5945D4BFE34CFFA055582499CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7567C209D01CC1E34B410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A503FBFE8BE8FC492D37EE74843A14FF395532641A7FAE987235790BDDF2831691BC2C1B508DF1F91D7E09C32AA3244C6FC54F9403E30090D24331C0341130EFF94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojIrFL/N5KnVGFi5fsbBBPtg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D3EF1263AC7454245DC0190F67FAEBF2CA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] luajit-gdb: support dualnum mode X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the fixes! LGTM now. BTW, I've reverted one fix proposed by Sergey (see the corresponding thread) and fixed a typo below. On 16.08.21, Максим Корякшин wrote: > > Hello, Igor! > Thanks for your comments! >   > Here is the new commit message: > ========================================================= > gdb: support LJ_DUALNUM mode >   > luajit-gdb.py displays integers in LJ_DUALNUM mode as nan-s. The > dumper function produces output considering any input value as a > double. However, in LJ_DUALNUM mode, integers and doubles are stored > differently, so the `itype` of a double must be less than > `LJ_TISNUM`, and the `itype` of an integer must be `LJ_TISNUM`. With > this fact in mind, we can easily differentiate one from another. >   > Closes tarantool/tarantool#6224 > ========================================================= >   > Here is the diff: > ========================================================= > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index 9ccca66a..25428745 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > @@ -507,10 +507,14 @@ pointers respectively. >      ''' >      def invoke(self, arg, from_tty): > -        gdb.write('LJ_64: {LJ_64}, LJ_GC64: {LJ_GC64}\n'.format( > -            LJ_64 = LJ_64, > -            LJ_GC64 = LJ_GC64 > -        )) > +        gdb.write( > +            'LJ_64: {LJ_64}, LJ_GC64: {LJ_GC64}, LJ_DUALNUM : {LJ_DUALNUM}\n' Side note: Excess whitespace. I've fixed this before merging the patch into the trunk. > +            .format( > +                LJ_64 = LJ_64, > +                LJ_GC64 = LJ_GC64, > +                LJ_DUALNUM = LJ_DUALNUM > +            ) > +        ) >  class LJDumpTValue(LJBase): >      ''' > ========================================================= >   > >  > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, IM