From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladimir Davydov <vdavydov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org,
yaroslav.dynnikov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] net.box: allow to store user-defined fields in future object
Date: Mon, 16 Aug 2021 11:56:53 +0300 [thread overview]
Message-ID: <20210816085653.GT27855@tarantool.org> (raw)
In-Reply-To: <20210816082705.scypk477pp335ahb@esperanza>
Vova,
Thanks for the fixes!
On 16.08.21, Vladimir Davydov wrote:
> On Sat, Aug 14, 2021 at 02:17:00PM +0300, Igor Munkin wrote:
> > On 13.08.21, Vladimir Davydov wrote:
<snipped>
> > > +future.abc = nil
> > > +---
> > > +...
> > > +future.abc -- nil
> > > +---
> > > +- null
> > > +...
> > > +future.abc = nil
> >
> > Looks like a typo: future.abc already equals to nil above.
>
> It's actually not a typo. I wanted to ensure that deleting a key that
> has no value works fine. Added clarifying comments.
Now I get it, thanks! Feel free to proceed with the patch then.
> --
<snipped>
--
Best regards,
IM
next prev parent reply other threads:[~2021-08-16 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 16:53 [Tarantool-patches] [PATCH] " Vladimir Davydov via Tarantool-patches
2021-08-10 17:15 ` Cyrill Gorcunov via Tarantool-patches
2021-08-11 7:49 ` Vladimir Davydov via Tarantool-patches
2021-08-12 17:07 ` [Tarantool-patches] [PATCH v2] " Vladimir Davydov via Tarantool-patches
2021-08-12 18:02 ` [Tarantool-patches] [PATCH] " Vladislav Shpilevoy via Tarantool-patches
2021-08-12 18:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-13 10:01 ` Vladimir Davydov via Tarantool-patches
2021-08-12 18:13 ` Igor Munkin via Tarantool-patches
2021-08-13 9:57 ` Vladimir Davydov via Tarantool-patches
2021-08-13 9:59 ` [Tarantool-patches] [PATCH v3] " Vladimir Davydov via Tarantool-patches
2021-08-14 11:17 ` Igor Munkin via Tarantool-patches
2021-08-16 8:27 ` Vladimir Davydov via Tarantool-patches
2021-08-16 8:56 ` Igor Munkin via Tarantool-patches [this message]
2021-08-16 11:32 ` Vitaliia Ioffe via Tarantool-patches
2021-08-16 11:35 ` Vladimir Davydov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816085653.GT27855@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] net.box: allow to store user-defined fields in future object' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox