From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BCB796EC40; Mon, 9 Aug 2021 13:39:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BCB796EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628505545; bh=mJG6DWplbZxrdUSQw3KcETWP26uuLlbFOMCAo0L21/U=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Z7TOLUGlYnsaWUiidGWpdes6OQv5D7j/4f2d2h6+KeqWxDhGTR/D7PJ7z3g23WCXn zJAfZuj3tnZRUDsosK+g2KCPzAsaw4J0/+MRyHbZGQOmjZq7sZIWEgXI100ZRzfapJ U+wUe58xbDWkC2mEOdk8n0XzVic/UzABehOLTdX8= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AC2656EC40 for ; Mon, 9 Aug 2021 13:39:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC2656EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mD2gQ-0007nq-Ns; Mon, 09 Aug 2021 13:39:03 +0300 Date: Mon, 9 Aug 2021 13:39:01 +0300 To: mechanik20051988 Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org, mechanik20051988 Message-ID: <20210809103901.7oiizs7cbtf3pzf4@esperanza> References: <06bcadd06bca14d32391e5612427b7b3f9084d26.1628184138.git.mechanik20.05.1988@gmail.com> <20210806125930.h4u3zpbrxbapwlfz@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210806125930.h4u3zpbrxbapwlfz@esperanza> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD910164DC12A5633065676A9727AC27C74182A05F538085040016234CAB617681D3169239A3F6BB02AF371A4C4B9F379E0228F6AFDAFD9C3F7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F09446BC3D835A58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379B0255B5E5688AF88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F45F424B7DC4FC62F329F2B552F716CF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2E71C9CEE48A59EEA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520140C956E756FBB7A618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A546D491EBCA279F9BA0F2DC2E635625B8082F5DAC259BE3F5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759F66ED85EB5F25FD410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C5CF6F4B28551E3F70E0C675ED03BB1609119BCCAA68F5DB627192993484A7EFFDADF29228A0BD761D7E09C32AA3244CEAAE397D83B991716E3B9ACD2B3C69B7B018FE5BB746DCD183B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGhQhWEp1aB81HA2i3flXFw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF904F1A7C6CC525F0861E3E5ECA634AD274CEFED1673C562683ABF942079399BFB559BB5D741EB966A65DFF43FF7BE03240331F90058701C67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 6/7] iproto: implement interactive transactions over iproto streams X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladimir Davydov via Tarantool-patches Reply-To: Vladimir Davydov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Aug 06, 2021 at 03:59:30PM +0300, Vladimir Davydov wrote: > On Thu, Aug 05, 2021 at 09:17:44PM +0300, mechanik20051988 wrote: > > + /* > > + * When we do any operations (which are written to `wal`) > > + * outside of transaction, we consider each such operation > > + * as a small transaction and write it to `wal` immediately. > > + * When operation is performed as part of transaction, we > > + * write all transaction to `wal` at the commit. In this case, > > + * `is_commit` flag will be set when writing to `wal` for the > > + * last operation in transaction, the rest operations must have > > + * this flag set to false, to mark that they all belongs to the > > + * same transaction. > > + */ > > + if (txn != NULL) > > + msg->header.is_commit = false; > > AFAIU this flag is used only when a statement is written to WAL. > Please remove. TX reuses request::header if it is set so is_commit would propagate to WAL and break recovery, which isn't what we want so this is technically correct. However, I think we should clear the whole request::header instead - we don't need it to apply a request, we only need it for replication. Will send a patch in reply to this email.