From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 813F5741FA; Fri, 6 Aug 2021 11:20:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 813F5741FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628238056; bh=IixUxoIrmGA1EyjQvDen06+aD/zzxozozxr5CiRbIqg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AWMUA9ytGYnpdYNYzo4q1SOvxEswrTIZLVY+3LfhOsUDxP0n6bqluG2UdhZdpEo+8 WN/iBUYbMEifrShJJbIqKk/JLoX4WQlK5Timg/v8RPv46HOhRPxowJyzfF11WDesdm IOHJZjFjAG6RfBxlvcV/L0hYvQuAg1mdpY7AtpJU= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 98414741F7 for ; Fri, 6 Aug 2021 11:20:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 98414741F7 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mBv66-0000Br-RE; Fri, 06 Aug 2021 11:20:55 +0300 Date: Fri, 6 Aug 2021 11:20:53 +0300 To: mechanik20051988 Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org, mechanik20051988 Message-ID: <20210806082053.4hcurxeuewqwnh53@esperanza> References: <7f1a921ef966fa619fb8bf1bda9f94d7f9c06c10.1628184138.git.mechanik20.05.1988@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f1a921ef966fa619fb8bf1bda9f94d7f9c06c10.1628184138.git.mechanik20.05.1988@gmail.com> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9BCE6B93DE0C6C3914462CDB1732D383C182A05F53808504010227419CF6F730F7909B03B1B2D5AC8CA1DFE0799459D25F1690EDA16D5502B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063757004B04402545C58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D822500CFC1CA2A5152A6B759F56670592117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC9FC99A4BA45EE8B4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5678459831AA2D5436F97DB2052E35A01BB699AEA36290763D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3480A9008907CB2FD0C98DF663E352F816515C7FDAACFAD1FD7DC9D56FCE045811599DD610CB52D80E1D7E09C32AA3244C17ACA756079B6BEC5837F029BC56C038F522A1CF68F4BE0583B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFhlvmGwdUwTTSUezKhAjRQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D1103064FA42197A3D628BC1AC0B656EA274CEFED1673C562683ABF942079399BFB559BB5D741EB966A65DFF43FF7BE03240331F90058701C67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/7] iproto: implement stream id in binary iproto protocol X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladimir Davydov via Tarantool-patches Reply-To: Vladimir Davydov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Aug 05, 2021 at 09:17:39PM +0300, mechanik20051988 wrote: > From: mechanik20051988 > > For further implementation of streams, we need to separate > requests belonging to and not belonging to streams. For this > purpose, the stream ID field was added to the iproto binary > protocol. For requests that do not belong to stream, this field > is omitted or equal to zero. For requests belonging to stream, > we use this field to determine which stream the request belongs to. > > Part of #5860 > > @TarantoolBot document > Title: new field in binary iproto protocol > > Add new field to binary iproto protocol. > `IPROTO_STREAM_ID 0x0a` determines whether a request > belongs to a stream or not. If this field is omited > or equal to zero this request doesn't belongs to stream. > --- > src/box/iproto_constants.c | 4 +- > src/box/iproto_constants.h | 1 + > src/box/xrow.c | 8 ++ > src/box/xrow.h | 5 ++ > test/unit/xrow.cc | 7 +- > test/unit/xrow.result | 168 +++++++++++++++++++------------------ > 6 files changed, 109 insertions(+), 84 deletions(-) LGTM