From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 993E16F3E0; Thu, 5 Aug 2021 14:54:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 993E16F3E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628164479; bh=g9ywS6FZkDQe+Mpscfx3/0YUsVNOLsDK4L3jssaDy7A=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=SF2ahJdJpYDylwVETFxOxOlGQnTMfluw20e09dn9UtSwujFZ3XzRY9iCOZKMWNyQ1 qmscd2TI21Mr3a0EIe8/kOI75YJgmZ7iU8NqIQPBCU+B7Bo1T136EKTmGA3ZmufzN4 zmW9JoIV1qKGQ5vfLdbQRdmakDpOhkrvh/Z5lnHY= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E4E4C6F3E0 for ; Thu, 5 Aug 2021 14:54:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E4E4C6F3E0 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mBbxN-0008NJ-Vp; Thu, 05 Aug 2021 14:54:38 +0300 Date: Thu, 5 Aug 2021 14:54:34 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210805115434.rq6q7aidydx6sv3g@esperanza> References: <21b94b5bea3b00bde3e866300992fbff78a76b5c.1627024646.git.vdavydov@tarantool.org> <1683388e-d329-947e-633a-ded9a123a923@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1683388e-d329-947e-633a-ded9a123a923@tarantool.org> X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9ECFD080E047A606F6525B29142351271182A05F538085040BE3EFCE790559643E371983B2B7A01B550C5F63ADC39A99D409AD3BB4172A54C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063706922F90966A37BA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C21BB57F0C2EC28462E91B0B037A4571117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5131F314FFE23FE4A2109AC1A3E86ADEC3ECCC6B1C8EC9D77D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342B94C1DAF75C4D224468B50364831C2EB50645AE23431A33E3E35A3BA1D74B0F33441015408AC53F1D7E09C32AA3244CFBC12697BDE97F5A9A324B693B27CEB68894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3X+/9Fh2MXhOw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D91FC013D9AE8D4B5D47FFBF9B7418FF1274CEFED1673C562683ABF942079399BFB559BB5D741EB966A65DFF43FF7BE03240331F90058701C67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 18/20] net.box: rewrite iproto handlers in C X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladimir Davydov via Tarantool-patches Reply-To: Vladimir Davydov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Aug 04, 2021 at 01:08:25AM +0200, Vladislav Shpilevoy wrote: > > +static int > > +netbox_iproto_auth(struct lua_State *L) > > +{ > > + size_t user_len; > > + const char *user = lua_tolstring(L, 1, &user_len); > > + size_t password_len; > > + const char *password = lua_tolstring(L, 2, &password_len); > > + size_t salt_len; > > + const char *salt = lua_tolstring(L, 3, &salt_len); > > + if (salt_len < SCRAMBLE_SIZE) > > + return luaL_error(L, "Invalid salt"); > > + struct netbox_registry *registry = luaT_check_netbox_registry(L, 4); > > + int fd = lua_tointeger(L, 5); > > + struct ibuf *send_buf = (struct ibuf *) lua_topointer(L, 6); > > + struct ibuf *recv_buf = (struct ibuf *) lua_topointer(L, 7); > > + double timeout = (!lua_isnoneornil(L, 8) ? > > + lua_tonumber(L, 8) : TIMEOUT_INFINITY); > > Timeout is never passed, it is always TIMEOUT_INFINITY. The same in > netbox_iproto_schema and netbox_iproto_loop. Fixed in a separate patch: https://lists.tarantool.org/pipermail/tarantool-patches/2021-August/025208.html