From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 995A36EC58; Wed, 4 Aug 2021 17:38:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 995A36EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628087935; bh=wdTj9RLqqfgCk7YmQqpCui9HKiIco9ELCohS4pU2YyY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Rmcc4q3H1B+pe3KxR3ohwUMuci1jWrXPKJNk1x1LHviJ9EsoZHfckAxyn+BPNLJCk PpigNxHTQDMavcox7QaxXtq23FW9AZxM0eR1Am5JfCKHOGKEXmw1Y7HyX7XEGAIFic 7S4iYouAYt7U9FxONeJtp8JddiCbmodt8DuOa1ik= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 52C356EC58 for ; Wed, 4 Aug 2021 17:38:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 52C356EC58 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1mBI2n-0007tw-L0; Wed, 04 Aug 2021 17:38:54 +0300 Date: Wed, 4 Aug 2021 14:38:53 +0000 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210804143853.m6kkngmr2kzdncom@tarantool.org> References: <5633585cd575c556b6eb132458863ebc1731126b.1628066170.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5633585cd575c556b6eb132458863ebc1731126b.1628066170.git.imeevma@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F5380850403DF71C4F5D90A1D784ED06864057AE726191FE03B59317ED729EB31704CFAC04 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D64EDD178B2A1008638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83668588EDB31B7E0881744E909997E89117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCBCFBAF3982895081A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACDF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C60910C30DCD593B16E0066C2D8992A164AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3091AF3C34090AE74BA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505C206982B72325540938AB5219E30ECDD X-C1DE0DAB: 0D63561A33F958A52295C39C8367E493C5981D97C4552E21B7D1A7C6E70675BBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3450C5E6D685282BA1D523A8251DEE55EA224EF6104B24D6642C32D7CF03FB187851A9BB98A05DD3631D7E09C32AA3244C6ED5EA130CDFFE38E76EF4226EA97A63B038C9161EF167A1729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeDyvyeZJDJFRNS6iJpEM3g== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD240AA2FEBEA528A776AD4A25365202E15672B1FA5F7FA4D7CCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: implicit cast rules for arithmetic operations X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 04 авг 11:36, imeevma@tarantool.org wrote: > After this patch, arithmetic operations will only accept numeric values. > For the "%" operation, the rules have become even stricter, now it > accepts only INTEGER and UNSIGNED values. > > Part of #4470 > Closes #5756 > --- > https://github.com/tarantool/tarantool/issues/5756 > https://github.com/tarantool/tarantool/tree/imeevma/gh-5756-implicit-cast-in-arithmetic The patch LGTM. -- Regards, Kirill Yukhin