From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 48FC26EC58; Wed, 4 Aug 2021 17:16:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 48FC26EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628086587; bh=HzYD7vmDcJV4NEItKQYCQehfts3bGFHxCcYIzGlVL3A=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IHlG5EKnTc6mxv+Qmey+iOp0YKlUwl0I3flKZ1XMliFFofyYIVX+joCC5VxuuvbN3 ArWseR6OXp8fycjXWkjkjQQR5AjVO2H2fjHv9zQwgO0cGlYrr/CQPRusVawVk+qhim maiLPZ6pppWazYrraJY5uPSyY95G7mpVwXSntSTk= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1416B6EC58 for ; Wed, 4 Aug 2021 17:16:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1416B6EC58 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1mBHh3-0000ti-D0; Wed, 04 Aug 2021 17:16:25 +0300 Date: Wed, 4 Aug 2021 14:16:25 +0000 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210804141625.krom7aukl3pfe7kk@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F53808504059EC2B3C375F0BD4461881D9569B3B2A6191FE03B59317ED8463995BEF51BE77 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063781BF90BB6B3E56078638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8136B5826D35C6248741E38BA0DD8E524117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FE9D765CF6BB0EE041D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3457EE4B4996FC546040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006371F24DFF1B2961425731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5738F951166458A0C5D63995BDCB2EB5A37CDDBA9EE74FF02D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346AD04FDA812EEFF13FE9B045BA7736D2ADC2AE213CC3CC494696D61A6FB04238F4E4B80D2E001FE91D7E09C32AA3244C0478E7C14CF8217EAB3022887502878AB038C9161EF167A1729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeDyvyeZJDJF/gtlzIysuPw== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD243D56CD4EB48F35D5B9D3C455CE60FA6CC1E01A242E67BBBCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 0/3] Fix explicit casts X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 04 авг 11:32, imeevma@tarantool.org wrote: > This patch fixes the explicit cast to comply with the new rules. According to > these rules, BOOLEAN and VARBINARY can no longer be cast to numeric types. > > https://github.com/tarantool/tarantool/issues/4470 > https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-fix-explicit-cast > > Changes in v2: > - Change of str_to_bool() were moved in new patch. > > Mergen Imeev (3): > sql: disallow explicit cast of BOOLEAN to number > sql: disallow explicit cast of VARBINARY to number > sql: fix STRING to BOOLEAN explicit cast The patch set LGTM. -- Regards, Kirill Yukhin