From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 408696EC58; Mon, 2 Aug 2021 10:36:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 408696EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627889816; bh=5+oezt3YmmWT40FQoqu9cJPAUGrc4fdS5vo3D8tOtx8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Ou7bBG80yXSF7VHUETq5oRbFlWrfZ7FgX8enF8wTdrlcMGK6Dfq40EahH2C3MMUBH d+RCbws34/jcy3OjOv0tjrRGNJAw8ZbZl8gmyv/xvON1k+rEYdGllOzCYB+76I7+p7 RDOnnrAowO9GfkcXvfS6Y92V7HT18lBH0SSfDvIA= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CC5CC6EC58 for ; Mon, 2 Aug 2021 10:36:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CC5CC6EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mASVK-0008Fc-0U; Mon, 02 Aug 2021 10:36:54 +0300 Date: Mon, 2 Aug 2021 10:36:49 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210802073649.mbcs673fxheikcsy@esperanza> References: <6c3509125f24f6276be678d6b8f1ac264631d048.1627024646.git.vdavydov@tarantool.org> <20210730084419.vywinihhqdik74mr@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30A5AB0699C09BB51E5FD76225F0C99C3182A05F538085040EB64377A146F1EB35DCC93D360DD60329266771DFE1856CAAC58F9DE6E6ADA73 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063707C1E244DAE02CF68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D856FF739D9F0B8D6444C39CE52FF3F0E6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F217EDBC4C5F0C90A6F2A2C4B7B72BBA3ECE6ED0A9897665D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344888A9AABCDD322568C639ECAC1E8979CCD61BEFE3F4D8B103809FF4AD57D956B43EA83C7CCBBA531D7E09C32AA3244C36D2588AB04D883C7E0BF2E1AB04B6EF408A6A02710B7304FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMCfuYI4Pred5ysFiU1yV3Q== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D5B56EBF1047A06C67B621AC4F9C4D23E274CEFED1673C562683ABF942079399BFB559BB5D741EB966A65DFF43FF7BE03240331F90058701C67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 11/20] net.box: rewrite response decoder in C X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladimir Davydov via Tarantool-patches Reply-To: Vladimir Davydov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sat, Jul 31, 2021 at 12:12:51AM +0200, Vladislav Shpilevoy wrote: > Thanks for the fixes! > > > diff --git a/src/box/lua/net_box.c b/src/box/lua/net_box.c > > index 2d2562550752..ac9052de286c 100644 > > --- a/src/box/lua/net_box.c > > +++ b/src/box/lua/net_box.c > > @@ -664,7 +664,7 @@ netbox_encode_method(struct lua_State *L) > > return 0; > > } > > > > -/** > > +/* > > There is misunderstanding, sorry. As doxygen I meant only these > '@a param desc' lines. The /** are a part of our code style, look: > https://github.com/tarantool/tarantool/wiki/Code-review-procedure#code-style > > All out-of-function comments use /** on the first line, all comments inside > of functions use /* on the first line. > > After your fix this - the commit LGTM. Fixed and pushed to master.