From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B96C56EC55; Thu, 29 Jul 2021 12:46:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B96C56EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627551962; bh=yhMbqoLjadVaz+YUgkzImlpYQuoaJzX7BqBlgQAJNVs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tbGxTqQSL65bCpTno8ygKhd8/rTVO1EhyfDqmhVy2qMEsqqjfd3KPjysicp5LiNGe xNdFShyXSPGQi5tpiyhR1N9SCVdcd5lac0eqIwGyfG0CA7IP7qgFh8E9m5xDq8eoox k33VaCwRe7map9T/ERxt5uxlBwnQEgXK6CKBPgYg= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 43C8B6EC55 for ; Thu, 29 Jul 2021 12:45:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 43C8B6EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m92c0-0007nt-8g; Thu, 29 Jul 2021 12:45:56 +0300 Date: Thu, 29 Jul 2021 12:22:20 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: <20210729092219.GT27855@tarantool.org> References: <1627494133.365921222@f190.i.mail.ru> <1627550343.125610573@f728.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627550343.125610573@f728.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F53808504079F2C40A48641322C8F142DA2D23609F8FBE3AB32B16222B282AEB0C3F433EE3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745229D52CF30560CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BA5555A0C16230F4EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2C58CA86DC8C6B8C4CBFAC15DA1728C7DCC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5EEC35501BEB928F5F8408A4BE7957DFF2987E1FE40730655D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454E98140CCACB5B3B5A1848C89CD0E3E174E8739197E813F7C068631609C02D82A0F4CD20271DE161D7E09C32AA3244C15CAC01CFEA6681693575DECA944A2BB7C0C08F7987826B983B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPp/mPgZxawEIUR0200O00g== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D8DA8666235D2660C9277FC770A3A1E5AA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the fixes! Just my two cents for the change below. On 29.07.21, Максим Корякшин wrote: > > Hi! Thanks for the review, Sergey! > Here is the diff, which will add support of OOS build and will adjust > comment in CMakeLists: > ============================================================================================ > diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt > index b9804033..90b4209a 100644 > --- a/test/lua-Harness-tests/CMakeLists.txt > +++ b/test/lua-Harness-tests/CMakeLists.txt > @@ -10,10 +10,10 @@ if(NOT PROVE) >    return() >  endif() > -# Tests create temporary files (see 303-package.t for example) > -# to require. Also, they require some files from original > -# test source directory. > -set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua") > +# Tests create temporary files (see 303-package.t and 411-luajit.t for > +# example) to require. Also, they require some files from original test > +# source directory. We try to box our comments up to 66 symbols. This is not a strict rule anymore, but if you can follow this, please do. Feel free to ignore. > +set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua\;${CMAKE_BINARY_DIR}/src/?.lua") There is LUAJIT_BINARY_DIR variable, so please use either both LUAJIT_*_DIR or CMAKE_*_DIR/src for consistency. BTW, consider the difference between CMAKE_*_DIR and PROJECT_*_DIR, so I'm sure you need the latter one. >  set(LUA_TEST_FLAGS --failures --shuffle) >  if(CMAKE_VERBOSE_MAKEFILE) > ============================================================================================ >   >   > >  > >  -- Best regards, IM