From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AB5386EC55; Wed, 28 Jul 2021 16:43:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AB5386EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627479796; bh=sELagTIIMfMQjfJYG7NAZ89zTuC2Zt+OO1au3hGsB6c=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=R5mz+ysfx6QhaYEy6oInThG8jOHtZwuAQBdiJBJu0ehV9SH3YbtdPxjcD5zPhq3py yPYhccEk5zzAjxSlx+a7yzfTs7DKf8HR6nOnYqQdy5itvFEZ1KvEqIARrhWKVWqUWB yXaIUe6iw//L9yT5X/kqwIUgWJJT7pS+HoNx9RVI= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0CE2F6EC55 for ; Wed, 28 Jul 2021 16:43:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0CE2F6EC55 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1m8jq5-0003Ga-N4; Wed, 28 Jul 2021 16:43:14 +0300 To: tarantool-patches@dev.tarantool.org, imun@tarantool.org, skaplun@tarantool.org Date: Wed, 28 Jul 2021 20:42:57 +0700 Message-Id: <20210728134259.1113235-1-m.shishatskiy@tarantool.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F538085040DA0B6D4B5617DAEE337FAD48F3CD0029311B733A7A4FAF42E618E5100F54CA1A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063721F819F5952827038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81418492FC6F716EECC34D69690934ADF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC24E1E72F37C03A0A5FD2DD08EB4836CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE364E7220B7C5505926E0066C2D8992A16C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C7BEA09003D200E08B141BC0B414BF04407C0AFF2527451CE9C2B6934AE262D3EE7EAB7254005DCED3A96BCF046FC1CF19510FB958DCE06DB6ED91DBE5ABE359A7EE5648E065588D423D4379F09C64C7393EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E229BE567979C9402A6516CCA83EF2C352ADD77FD17407EF2A6CF5A30C88C99E1B95F52257D2EA4D1D7E09C32AA3244C05B85A391A116D68D9AC6E8DD6DEAE7F7101BF96129E4011927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiF1u9eOpfTTS5lVlmOxAjw== X-Mailru-Sender: 2317F5BEA8D613097CB8A225516EF027BE1BAC68D3663C056D04B2EFE2575E571C94318A7F530E3EFF6B26DEAE20951894E739346DD9ABB838AE394B99C5394F99323991B04ED3930F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: [Tarantool-patches] [PATCH luajit v2 0/2] memprof: group allocations on traces by trace number X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mikhail Shishatskiy via Tarantool-patches Reply-To: Mikhail Shishatskiy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" New patch series with Sergey's comments in mind. Changes in v2: - Fixed comments as per review by Sergey Kaplun; - Trace dump supplemented with info about trace start pc, which is stored in the symtab; - Added test, checking if allocations in trace reported; - Ran an allocation-heavy benchmark on new patches to test the behavior. The benchmark payload code can be found at [1]. It was summoned from under the wrapper code [2]. The average time of 15 runs in seconds is presented below. The second field is the standard deviation for the found difference: | -------------------------------------- | | JIT-off, memprof-on | | -------------------------------------- | | BEFORE | AFTER | | ------------------ | ----------------- | | 9.6155 (0.0656) | +0.2951 (0.0742) | | -------------------------------------- | | JIT-on, memprof-on | | -------------------------------------- | | BEFORE | AFTER | | ------------------ | ----------------- | | 7.0037 (0.2044) | +0.2842 (0.0662) | | -------------------------------------- | [1]: https://github.com/LuaJIT/LuaJIT-test-cleanup/blob/master/bench/binary-trees.lua [2]: https://gist.github.com/Shishqa/d8e29f501d72647878b8993a206cea19 Issue: https://github.com/tarantool/tarantool/issues/5814 Branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number CI: https://github.com/tarantool/tarantool/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number Mikhail Shishatskiy (2): memprof: dump traceno if allocate from trace memprof: extend symtab with info about traces src/lj_memprof.c | 33 ++++- src/lj_memprof.h | 20 ++- .../misclib-memprof-lapi.test.lua | 121 +++++++++++++----- tools/memprof/parse.lua | 22 ++-- tools/utils/symtab.lua | 41 +++++- 5 files changed, 184 insertions(+), 53 deletions(-) -- 2.32.0