From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1D4A56EC55; Tue, 27 Jul 2021 12:11:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1D4A56EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627377061; bh=GKoTq7lRD/dHtldeqLnU8avtMf70eCT6lbV7DkY7FQM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AXDvW2GJvjAJW64+gAIrNHLo/5QXAKaJJ3y6Giu02NYLvgh5sE+nMJexMlb+Gf3lB oVUzkzb5JIvdzta4ntl6LOVkdjnyKaO0tEeoH/MpuKJiLdmSTDSi3Nnh27nRbSRTcB BdOvmlsY9YBygvqAju43h/X5KuVqEl4cCpwQ2meo= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 099CF6EC55 for ; Tue, 27 Jul 2021 12:11:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 099CF6EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m8J75-00010K-E5; Tue, 27 Jul 2021 12:10:59 +0300 Date: Tue, 27 Jul 2021 12:10:58 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210727091058.GA46068@tarantool.org> References: <8d11dffd7eb5c6a4d03081fe50042a42ee65d3f3.1627034042.git.imeevma@gmail.com> <451958bf-70bc-976b-4dbd-d747a480e4ce@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <451958bf-70bc-976b-4dbd-d747a480e4ce@tarantool.org> X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B2770D7874BA03B4AE182A05F5380850408E7324B532175F311FAF7ECF20A2CAE6303A7D4644CF21E3C7C149A39BA1962B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372D850D7477D401F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89251FC1B6C87AC82A175936DFCF7C39B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5092D5234CDAB75F6099E3D6EE487C52B702B5B98461F53C6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347324AA9FA07FF01E987772C44C09245A311A0BABE4203B919C04163B316E70396015EFDF5436F9E61D7E09C32AA3244CAFD688FD09F4AC3149713B0EDC75F4DE05AB220A9D022EBC729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5/RPO3G6bVPbw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D87E78BCE4017CD003FA80A6100697F7683D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: bit-wise operations now accepts only UNSIGNED X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! My answer below. On Mon, Jul 26, 2021 at 11:54:46PM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > On the branch I see 2 commits on top of the master. Did you > send the first commit anywhere? This one - "sql: clear MEM > only if necessary". I am not sure it is needed or even better > than it was before, because it adds a branch. I rebased this patch to current master and removed "sql: clear MEM ..." commit. That commit was to make simpler usage of mem_set_*() functions. However, later I understood that it is completely wrong, and even it was right it is not better than it is now.