From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E9AD66EC55; Mon, 26 Jul 2021 23:37:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9AD66EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627331856; bh=0Y+gAgrpa+fuQnwQdtiJvtdXZQr9x17P0EnVy6B5moI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Lo1oKYGPvlbNhVKE3QuoBpKEklynRdHVxMU75qjFrpg54I1ZKJ/1mbWFCD9RWzzg7 v58Bobm0SMAKOAA6BU3G5KyB17w0G/nf6+CECRAHceJ5JiSeySOLjwoTjG/i6kmOVF ojqofz+qIruXMj0ORtbTJvQZh44dds+E/TAI0DjA= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BAABF6EC55 for ; Mon, 26 Jul 2021 23:37:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BAABF6EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m87Lx-00080h-MU; Mon, 26 Jul 2021 23:37:34 +0300 Date: Mon, 26 Jul 2021 23:13:58 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: <20210726201358.GQ27855@tarantool.org> References: <1627302676.27157197@f710.i.mail.ru> <1627302729.534847627@f710.i.mail.ru> <1627302979.755910918@f710.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627302979.755910918@f710.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F538085040FE741D7547C82A24B8C5CBF71BF7B6225FDCE08F581A31565DA30A8CAFD5FEBB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063729381D024F10DD158638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D3228A2420D837B34F2A80F63F51730F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50566D5D5C7453E9A22EF76C01B2C4E1BDA X-C1DE0DAB: 0D63561A33F958A52A0BCC5782615455EE34BDF460C368100BB5824876DA3B79D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7517A45118377F5F9E8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B9F55CA4D2956E30440BB270054BABE1EC751C016346B28C65C0BC4180F3AB98B5642CB1FC704B951D7E09C32AA3244C5737414E55B7A5F0F92D8DBBDE13A5D7408A6A02710B7304927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5+qMQ17W98uHQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DC1E86CC90FDEFF44FDACA80A5F3B5851A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the fixes! LGTM, except a single typo. On 26.07.21, Максим Корякшин wrote: > > Sorry for the several emails, I have encountered some issues with the email client. >   > Anyway, here is the diff, that masks only one particular assertion instead of masking all of them: > ======================================================================== > diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > index d5373b9f..bdd95514 100755 > --- a/test/lua-Harness-tests/241-standalone.t > +++ b/test/lua-Harness-tests/241-standalone.t > @@ -51,10 +51,6 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then >      skip_all "io.popen not supported" >  end > -if jit.os == 'BSD' then > -    skip_all "BSD is not supported yet" > -end > - >  plan'no_plan' >  diag(lua) > @@ -116,22 +112,24 @@ f = io.popen(cmd) >  equals(f:read'*l', 'Hello World', "redirect") >  f:close() > -cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" > -f = io.popen(cmd) > -matches(f:read'*l', banner, "-i") > -if ujit then > -    matches(f:read'*l', '^JIT:') > -end > -if ravi then > -    matches(f:read'*l', '^Copyright %(C%)') > -    matches(f:read'*l', '^Portions Copyright %(C%)') > -    matches(f:read'*l', '^Options') > -end > -if _TARANTOOL then > -    matches(f:read'*l', "^type 'help' for interactive help") > +if jit.os ~= 'BSD' then > +    cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" > +    f = io.popen(cmd) > +    matches(f:read'*l', banner, "-i") > +    if ujit then > +        matches(f:read'*l', '^JIT:') > +    end > +    if ravi then > +        matches(f:read'*l', '^Copyright %(C%)') > +        matches(f:read'*l', '^Portions Copyright %(C%)') > +        matches(f:read'*l', '^Options') > +    end > +    if _TARANTOOL then > +        matches(f:read'*l', "^type 'help' for interactive help") > +    end > +    equals(f:read'*l', 'Hello World') > +    f:close() >  end > -equals(f:read'*l', 'Hello World') > -f:close() >  cmd = lua .. [[ -e"a=1" -e "print(a)"]] >  f = io.popen(cmd) > ======================================================================== >   > And here is the fixed commit message: > ======================================================================== >     test: disable 241-standalone.t on FreeBSD >   >     Tarantool interactive mode misbehaviour has been found on >     FreeBSD (for more info see tarantool/tarantool#6231). Hence, this[1] >     particular assertion is masked for FreeBSD until the mentioned issue >     resolves. Typo: s/resolves/is resolved/. >   >     [1]: https://framagit.org/fperrad/lua-Harness/-/blob/master/test_lua/241-standalone.t#L115-130 >   >     Part of tarantool/tarantool#5970 >     Part of tarantool/tarantool#4473 >     Relates to tarantool/tarantool#6231 >   > ======================================================================== >   >   -- Best regards, IM