From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 605366EC55; Mon, 26 Jul 2021 20:43:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 605366EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627321432; bh=+U1qMtiAU9eBslR0EPfzz+bGMzWUSzpmh6lYRVd5mZo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wxTpAahXIGPdVecZhqKBEPtkTIwalJNi9XJDTX+xKAEbkxRZ8JV4lMkBy/N6/+wzF l7hkhuVmO+SMYGUZCzyKVxwmURHipGtWFVukV4nMgzKsbhhW+HG7yh1uwH6eMC/q/j Wl741PwZz9BpbLG6qamT1da7ITGa+fISlp6jpb2Q= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DB9116EC55 for ; Mon, 26 Jul 2021 20:43:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB9116EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m84dp-0007qJ-Kj; Mon, 26 Jul 2021 20:43:50 +0300 Date: Mon, 26 Jul 2021 20:20:14 +0300 To: Alexander Turenko Message-ID: <20210726172014.GM27855@tarantool.org> References: <20210726162526.ud6ikavqybz4looc@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210726162526.ud6ikavqybz4looc@tkn_work_nb> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30288BCF456A452EC429C5145D5B58EFD182A05F538085040D5759B166D31690CDF66B58C27BECBAAEF1B95B9C9B6BE25044C59A3D9CAF4E7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CC84CC3AD347B910EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FA81DCE0280C9CC68F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB553375667BEA09003D200E0872B0AC4CE9727141E53677558504845DA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637427B078F297B269AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5371B9AC81C4F5D7A9D4B7DCFABA206C19CD9A7B4F2FB3E24D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7517A45118377F5F9E8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341E08D7EE1804B7631FF856A6156913C62EC7026F640539CFC25FA3D694F64187973081D40DD4A7BF1D7E09C32AA3244CB92AD5CBE615F1E4C2B98937F0FA275A1E098CBE561D6343927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5937oWNkE7s0Q== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF99F082B2D311AE3AD3089509A3849EFA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] test: enable JIT for Lua Fun chain iterator back X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sasha, Thanks for your review! On 26.07.21, Alexander Turenko wrote: > On Sat, Jul 24, 2021 at 08:24:54PM +0300, Igor Munkin wrote: > > This patch reverts the temporary fix introduced in commit > > 5fa7ded22c1f6b5ab2ed78563538d234776bac76 ("test: disable JIT for Lua Fun > > chain iterator") since the issues with invalid traces generation for > > iterator are resolved and JIT can be enabled back then. > > > > Follows up #4252 > > Follows up #5118 > > > > Signed-off-by: Igor Munkin > > --- > > > > Related issues: > > * https://github.com/tarantool/tarantool/issues/5118 > > * https://github.com/tarantool/tarantool/issues/4252 > > * https://github.com/LuaJIT/LuaJIT/issues/584 > > Branch: https://github.com/tarantool/tarantool/tree/imun/lj-584-bad-renames-for-sunk-values > > CI: https://github.com/tarantool/tarantool/commit/b35e2ee > > > > test/box-tap/key_def.test.lua | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/test/box-tap/key_def.test.lua b/test/box-tap/key_def.test.lua > > index 41eed2191..2ade668a5 100755 > > --- a/test/box-tap/key_def.test.lua > > +++ b/test/box-tap/key_def.test.lua > > @@ -5,13 +5,6 @@ local ffi = require('ffi') > > local json = require('json') > > local fun = require('fun') > > > > --- XXX fix for gh-4252: to prevent invalid trace assembling (see > > --- https://github.com/LuaJIT/LuaJIT/issues/584) disable JIT for > > --- iterator (i.e. ). Since the function > > --- is local, the dummy chain generator is created to obtain the > > --- function GC object. > > -jit.off(fun.chain({}).gen) > > - > > local key_def_lib = require('key_def') > > > > local usage_error = 'Bad params, use: key_def.new({' .. > > I cannot say much about the fix itself. So I'll just ensure that the > test is stable now. > > Please, also remove the test from the fragile list in I didn't touch suite.ini since there is another issue mentioned with no checksums at all. Now I see this is a duplicate of #4252, so I removed it and mentioned #5049 in the commit message. Here is the diff: ================================================================================ diff --git a/test/box-tap/suite.ini b/test/box-tap/suite.ini index d854fddbb..b09d7db4f 100644 --- a/test/box-tap/suite.ini +++ b/test/box-tap/suite.ini @@ -12,9 +12,6 @@ fragile = { "issues": [ "gh-5346", "gh-4344" ], "checksums": [ "d41d8cd98f00b204e9800998ecf8427e", "53be182412baa1509cb7a3e27beca3ed" ] }, - "key_def.test.lua": { - "issues": [ "gh-5049" ] - }, "net.box.test.lua": { "issues": [ "gh-5346" ], "checksums": [ "d41d8cd98f00b204e9800998ecf8427e" ] ================================================================================ > test/box-tap/suite.ini. After this change the patch LGTM. Added your tag: | Reviewed-by: Alexander Turenko > > How I tested: > > $ ./test/test-run.py $(yes box-tap/key_def.test.lua | head -n 1000) > > I run it with and without c4bbd4013711c33c3ced9c2e8ac31a80992d2cf0 > ("luajit: bump new version: Detect inconsistent renames even in the > presence of sunk values."). > > Before the patch it usually fails. After applying the patch: nope, works > fine. Neato, thanks for verifying! > > WBR, Alexander Turenko. -- Best regards, IM