From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6C8A36EC55; Mon, 26 Jul 2021 19:25:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6C8A36EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627316752; bh=XhRJ+jY4I9Gv8I+iSm97tbeCJI+Zx0q6khFWxuPJzlI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=d5wfeQH6iz3C1Oqe8Yct+oEt7QX1a1dobIKtQhMXJ2K8m13jNpYNCleb6+CaLcuA6 XHPwDiEvHgqrI3CIaJ0C8EpRJrzf3l3AcvPERfHmluu+nOBs2zm21mFWeNKmF392Gp oY5K0Ff2jv1KGBYCfV7QXhQQb+f96i+LNZ3TxFfw= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 184456EC55 for ; Mon, 26 Jul 2021 19:25:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 184456EC55 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1m83QM-00089t-6k; Mon, 26 Jul 2021 19:25:50 +0300 Date: Mon, 26 Jul 2021 19:25:26 +0300 To: Igor Munkin Message-ID: <20210726162526.ud6ikavqybz4looc@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F53808504035A464FA67A3D5DBF213CC541A6D940A309833FBE346141FF81DEEB39643862D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922D113DFDC6D5A3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D8F5094E9BAC3E9F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8402F6932DCFC6582D141912B4F4DC930117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EECCD848CCB6FE560C269E641683F5DD3FD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3C6602A96AF88C695302FCEF25BFAB345C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A58ECD9C3B021B33817414F73A8B4C629437E054F604135918D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7517A45118377F5F9E8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34103A2CD2CFC42C678E3117D082323BA945391323FB88544BA974BE98B0D8FCDBC603593713E93EAF1D7E09C32AA3244C1097BF486A4525426716516B2954AFDC259227199D06760AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5/C4szboj6k4g== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE3812193C3C82F7BCD17DB127DC21256EB7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] test: enable JIT for Lua Fun chain iterator back X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sat, Jul 24, 2021 at 08:24:54PM +0300, Igor Munkin wrote: > This patch reverts the temporary fix introduced in commit > 5fa7ded22c1f6b5ab2ed78563538d234776bac76 ("test: disable JIT for Lua Fun > chain iterator") since the issues with invalid traces generation for > iterator are resolved and JIT can be enabled back then. > > Follows up #4252 > Follows up #5118 > > Signed-off-by: Igor Munkin > --- > > Related issues: > * https://github.com/tarantool/tarantool/issues/5118 > * https://github.com/tarantool/tarantool/issues/4252 > * https://github.com/LuaJIT/LuaJIT/issues/584 > Branch: https://github.com/tarantool/tarantool/tree/imun/lj-584-bad-renames-for-sunk-values > CI: https://github.com/tarantool/tarantool/commit/b35e2ee > > test/box-tap/key_def.test.lua | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/test/box-tap/key_def.test.lua b/test/box-tap/key_def.test.lua > index 41eed2191..2ade668a5 100755 > --- a/test/box-tap/key_def.test.lua > +++ b/test/box-tap/key_def.test.lua > @@ -5,13 +5,6 @@ local ffi = require('ffi') > local json = require('json') > local fun = require('fun') > > --- XXX fix for gh-4252: to prevent invalid trace assembling (see > --- https://github.com/LuaJIT/LuaJIT/issues/584) disable JIT for > --- iterator (i.e. ). Since the function > --- is local, the dummy chain generator is created to obtain the > --- function GC object. > -jit.off(fun.chain({}).gen) > - > local key_def_lib = require('key_def') > > local usage_error = 'Bad params, use: key_def.new({' .. I cannot say much about the fix itself. So I'll just ensure that the test is stable now. Please, also remove the test from the fragile list in test/box-tap/suite.ini. After this change the patch LGTM. How I tested: $ ./test/test-run.py $(yes box-tap/key_def.test.lua | head -n 1000) I run it with and without c4bbd4013711c33c3ced9c2e8ac31a80992d2cf0 ("luajit: bump new version: Detect inconsistent renames even in the presence of sunk values."). Before the patch it usually fails. After applying the patch: nope, works fine. WBR, Alexander Turenko.