From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E26F36EC55; Mon, 26 Jul 2021 00:41:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E26F36EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627249275; bh=5trCQ6xKn7H00p5jVaD3Bk9bEMvp/5fulb5u7XtK0hU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XmrHF236OliRaoFjtP39kIs8o8UQRp+l4nGOovLDvhzsPo9iWuEkoz6vLOsaYbbSf rB/dRAweyJy8FojIQ/mUECt29sJ+uf29zyFkMgQQGpHWNRjlRytjAMiGTZeMdFsgwa bYdiT7gk5OdBTY2WhlKO7jxfqVUJI1jxwExnNTng= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EC8536EC55 for ; Mon, 26 Jul 2021 00:41:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EC8536EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m7ls0-0008RT-3K; Mon, 26 Jul 2021 00:41:12 +0300 Date: Mon, 26 Jul 2021 00:17:36 +0300 To: Maxim Kokryashkin Message-ID: <20210725211736.GL27855@tarantool.org> References: <7cade1da865db38971b98e27093a474f43c86982.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7cade1da865db38971b98e27093a474f43c86982.1626797225.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30A5AB0699C09BB51962E4FF0DD431C8A182A05F53808504098E241F5DA4A0939909D65BDFA19C96ED9E9A72F010187612B4D93B172B817BF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D3BE5B596754B8C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE75263010198C72082EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2417E069495B5EA27E9977FFF2D11AF45CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505B5CFE43269A0DD27E3E98564226B18FA X-C1DE0DAB: 0D63561A33F958A57B443B5B9F801E2AB5931797E424B08DB235B24B3E7031F3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FDC9529E4578B99CB64EC2A200ABFD5BDDED31A0FA14ED45BD892C8410B86A4109F843ECBEF383561D7E09C32AA3244C4AA6719DE48388B7AE64D0643B3EA79055E75C8D0ED9F6EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW354VDTrtj5Rg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D6E47588BEECC7703D754E40974FDE34BA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! Please consider the comments below. At first, commit subject exceeds 50 symbols and the message exceeds 72 symbols. Please check this patch against our guidelines[1]. On 20.07.21, Maxim Kokryashkin wrote: > Tarantool interactive mode misbehaviour has been found on FreeBSD (for more info see #6231). The issue is mentioned the wrong way. The right format is tarantool/tarantool#6231. > Hence, this particular assertion is masked for FreeBSD until the mentioned issue resolves. Strictly saying, you skipped all assertions (not only those using broken interactive mode), not the particular one. > > Resolves #5970 This patch doesn't resolve the issue, since Tarantool profile introduced in "[PATCH v2 06/10] test: support tarantool in lua-Harness" is not used by Tarantool CI. Hence this is only "Part of" patch. > Part of #4473 BTW, both issues are also mentioned the wrong way. The right format is tarantool/tarantool# for both cases (see the previous patches in the series for the examples). It's also worth to add "Relates to tarantool/tarantool#6231". > --- > Additional info: https://github.com/tarantool/tarantool/issues/5970#issuecomment-883253400 > > test/lua-Harness-tests/241-standalone.t | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > index afbcf5b8..d5373b9f 100755 > --- a/test/lua-Harness-tests/241-standalone.t > +++ b/test/lua-Harness-tests/241-standalone.t > @@ -51,6 +51,10 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then > skip_all "io.popen not supported" > end > > +if jit.os == 'BSD' then > + skip_all "BSD is not supported yet" > +end At first, please add a comment with the rationale for this change. Furthermore, it's better to skip only assertions using interactive mode and run other assertions related to CLI behaviour. > + > plan'no_plan' > diag(lua) > > -- > 2.32.0 > [1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/ -- Best regards, IM