From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B4C076EC55; Mon, 26 Jul 2021 00:38:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B4C076EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627249110; bh=lo7enGD5hXyU2hRvWvJDMowyZN5p81QI4zlH9+n7fhQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F1tCw+V0D8GDC6HYvX39hxFRT1yisinFlRaW+lWrrVozHgpYOLoZz7GQi3dqMEqPM XaBUlpkeoWgEIrHDHKAxw/ppdoQhfqLTnad/yD7GjN9QTTbOiMMozsmRVF1PL+3q3I gtaNOC+GBzcX4/4fyIx3QB9UbKrmkLm2oruBWltY= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C02106EC55 for ; Mon, 26 Jul 2021 00:38:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C02106EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m7lpJ-00074f-SS; Mon, 26 Jul 2021 00:38:26 +0300 Date: Mon, 26 Jul 2021 00:14:50 +0300 To: Maxim Kokryashkin Message-ID: <20210725211450.GK27855@tarantool.org> References: <72be0416bbad48dca0240fbb8046ee5e6e596227.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <72be0416bbad48dca0240fbb8046ee5e6e596227.1626797225.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3FDAB68B812060C77E621B90589399EB5182A05F538085040372A1F5D9FAAB7267EBE0E0A0D445219D02FCEF427B98608E50360AEF009A3FA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637652CD06254D2F21C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D819074B89B5ABB9BF7F1408BEC9A3E549117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BF3059D42242344A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505B5CFE43269A0DD279B4F976604943C85 X-C1DE0DAB: 0D63561A33F958A55C4E7953657EB6924A6401AC74E920E733853FD6C87F722AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344B4608D01B1CB59A24E1BB828F6024090BBEDDFD3573F004B063F8411E09245C2C70A100DAD410231D7E09C32AA3244C17A1F59B8EDA01CD2CE714B67ECD55D0FE8DA44ABE2443F7927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW2CRL86mRCZXQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D8DAD64BF231131EE60BDBE98CF0ADAE8A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! Please consider the comments below. On 20.07.21, Maxim Kokryashkin wrote: > This patch backports several small commits from lua-Harness suite: > - follow ravi 1.0-beta4[1] > - refactor with near[2] > - follow LuaJIT[3] > - fix when no debug[4] > - check if luac exists[5] > - https[6] > - more assert[7] > > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b > [2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580 > [3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6 > [4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539 > [5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1 > [6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869 > [7]: https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2 The changes from the latter commit is missing. Furthermore, you've updated lua-Harness up to c4451fe, which is backported in scope of "[PATCH v2 01/10] test: port lua-Harness to Test.Assertion". Hence, the commit subject need to be updated too. > > Part of #5970 > Part of #4473 BTW, both issues are also mentioned the wrong way. The right format is tarantool/tarantool# for both cases (see the previous patches in the series for the examples). > --- > test/lua-Harness-tests/200-examples.t | 2 +- > test/lua-Harness-tests/203-lexico.t | 2 +- > test/lua-Harness-tests/241-standalone.t | 3 +- > test/lua-Harness-tests/242-luac.t | 4 +++ > test/lua-Harness-tests/301-basic.t | 2 +- > test/lua-Harness-tests/304-string.t | 2 +- > test/lua-Harness-tests/307-math.t | 44 +++++++++++------------ > test/lua-Harness-tests/310-debug.t | 2 -- > test/lua-Harness-tests/320-stdin.t | 14 +++++--- > test/lua-Harness-tests/401-bitop.t | 2 +- > test/lua-Harness-tests/402-ffi.t | 2 +- > test/lua-Harness-tests/403-jit.t | 2 +- > test/lua-Harness-tests/404-ext.t | 2 +- > test/lua-Harness-tests/411-luajit.t | 2 +- > test/lua-Harness-tests/profile_ravi.lua | 4 +-- > test/lua-Harness-tests/test_assertion.lua | 9 +++++ > 16 files changed, 57 insertions(+), 41 deletions(-) > > -- > 2.32.0 > -- Best regards, IM