From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 812566EC55; Mon, 26 Jul 2021 00:37:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 812566EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627249024; bh=DX80NK089ibB9cxnNwsi2vb/O9bfXX82tfIhzd7KN9A=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WSk7fX6ZWUtfy0JrsDohgSmNi9Y1EpQRIicsoDrHEV71GC/A7PSw7OmCJINQxVWMP bHkaK+80VbKfbWu4+GTdWC0J0jxEXQoEb9meYrpUG/VGS7y3F3xzsHosjwCtWh3uvY uGCamGDTI/6BBDQ/11hgkRh5eLcLA2JuBa5qO9Vg= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 63A046EC55 for ; Mon, 26 Jul 2021 00:37:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 63A046EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m7lny-0006VE-Dm; Mon, 26 Jul 2021 00:37:02 +0300 Date: Mon, 26 Jul 2021 00:13:27 +0300 To: Maxim Kokryashkin Message-ID: <20210725211327.GJ27855@tarantool.org> References: <39f288e9c6c4722433599ab33371ecd2470f1125.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <39f288e9c6c4722433599ab33371ecd2470f1125.1626797225.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30A5AB0699C09BB51962E4FF0DD431C8A182A05F53808504068097245C79F70C9F5EC10AF98B67D8219D29B9CE0272CA442E7F460570E63CE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7E044D6BF4785D596EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F22E62420B6A503CBDFAE3D3B866B554DFCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505B5CFE43269A0DD277B1A187F787C3AFF X-C1DE0DAB: 0D63561A33F958A524FC15877039BB4D46CC48FFACA0023A91E64952E46E5162D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF1A4EB32EA6BD2A0FF841EC7883E9124AE5E16904C54CC033DF1A462341C8B84DC1D7E09C32AA3244C59CCFB527808AFD8ADB3DBBD683276CA3E8609A02908F271927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW2i7vMZ/7O5/Q== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D4E0FE3C30DE922304085D1F7CDF55C31A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! The changes are fine, but please consider the comments below regarding the commit message. On 20.07.21, Maxim Kokryashkin wrote: > The patch[1] from lua-Harness suite adds some specific checks to > lua-Harness tests, so they are compatible with Tarantool now. Strictly saying, no *new* checks are *added*, but the *existing* ones are *adjusted* considering Tarantool specifics. > > Considering this, commit d4e12d7ac28e3bc857d30971dd77deec66a67297('test: > disable LuaJIT CLI tests in lua-Harness suite'), which disabled > tarantool cli tests, can be superseded. No, it can't. The mentioned commit is superseded by "[PATCH v2 06/10] test: support tarantool in lua-Harness" in this series. > > As a result, the introduced assertion for Tarantool error message fails > on MacOS, since getopt_long(3) yields the error message without single > quotes wrapping the flag. Hence, this commit also includes fix for that > from patch[2] in the trunk. > > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b3 Minor: 7 digits are enough. This is not critical, but just odd to have two similar links with the different number of digits, so feel free to ignore this nit. > [2]: https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5 Please mention the related issues: #5970 and #4473. > --- > Additional information on issue with MacOS: > https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605 > > NOTICE: tests for this separate commit are failing on FreeBSD > > test/lua-Harness-tests/241-standalone.t | 79 +++++++++++++++++++------ > 1 file changed, 61 insertions(+), 18 deletions(-) > > -- > 2.32.0 > -- Best regards, IM