From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4C5D46EC55; Mon, 26 Jul 2021 00:36:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4C5D46EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627248960; bh=EFhL7kNz3IKRjkdq9BPj/dg32b7FDPs/ugz817mF01o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IptEaDF4Y0wtVE3wOq98ulU5uozH3zhuHgibRknm0HE/relkP7JmFOlAaW0orZHd4 SYH2Knr6hEcWjcJvSt/92MYKqq0m2Mg56/Vxe5oSO7IkXnUYlHuo6YTg2CD/U60mtI Tnpl0JwJO4jtHF/xmMkEoEq0NLpeuVzHrdzEihdc= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A0A176EC55 for ; Mon, 26 Jul 2021 00:35:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A0A176EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m7lmk-0003RU-Rs; Mon, 26 Jul 2021 00:35:47 +0300 Date: Mon, 26 Jul 2021 00:12:11 +0300 To: Maxim Kokryashkin Message-ID: <20210725211211.GI27855@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C320FB367CC9CBEE800EEBD3117ABA9A5B182A05F538085040BBDB59AFCFDA08FDFD8EEA0121B2F8A05BA4F7EC9FF892F98A32F37E0E45CA0A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789805A6418246A1AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8F1A1743CF948808638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85F08479D973D156325C8F9A05E49ACC4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BF3059D42242344A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5053E9A111C50A71377F4699422909C03AA X-C1DE0DAB: 0D63561A33F958A531877FC75DDCAF533854D478B214257FB8D19C3556EB9EA7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3403182E70AE6895E007C2AE9CB43420BDF2DCE43909FBECAAF17AA64662035DB9DD6D44F623CCA1951D7E09C32AA3244C43568E1666C894940B44AE8C353F2EB3B018FE5BB746DCD1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW2f5nwnT6Fr3A== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D9C7BAED9ADF126AA62EE33E5C68F3C4CA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM, except the three typos. On 20.07.21, Maxim Kokryashkin wrote: > The patch[1] from lua-Harness fixes the same issue commit Typo: The link is missing. > 789820aac7cecc3b5ae394aadc12a5ec25b68121('test: fix directory detection Typo: Space is missing after the commit hash. > in lua-Harness suite') does, but it also works on Windows, so the > mentioned commit can be supreseded by that patch. Typo: s/supreseded/superseded/. > > Part of tarantool/tarantool#5970 > Part of tarantool/tarantool#4473 > --- > test/lua-Harness-tests/314-regex.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.32.0 > -- Best regards, IM