From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5D6AE6EC55; Mon, 26 Jul 2021 00:35:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5D6AE6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627248930; bh=17smb7b2fotMYF3QN3ASP2efEiZ1pHqJCIOscUHhhWU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vq7L72bq6HZZjeVuH8d8+7m706GdUtoEr1rLYsXvsrjC2g/7JZebuzTuMxp8hUFLB yo3xp3ZNZGLLzTAvqTDzmFZ6jFxPIhwwUUfZvgXhIsO5m7uP7ok9Ofp2lAVbW0k028 +krKCKJ6MYK+4UACKlTpRXH7X7wW2lhWR60fbQ8k= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9E1FC6EC55 for ; Mon, 26 Jul 2021 00:35:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9E1FC6EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m7lmR-0003J7-4B; Mon, 26 Jul 2021 00:35:27 +0300 Date: Mon, 26 Jul 2021 00:11:51 +0300 To: Maxim Kokryashkin Message-ID: <20210725211151.GH27855@tarantool.org> References: <3c7f4b9f754b86daaa59bc6663fb8235d4ee7e56.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3c7f4b9f754b86daaa59bc6663fb8235d4ee7e56.1626797225.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C386C8E0DDEE7E2465724AB895DD30A549182A05F5380850406F50118DAEF48DCA4DC2B6ADD8C38A12463DB03E56ECC9362DED7A9D51D4EAA7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379B0255B5E5688AF88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E51CCC4502275F740C407763785A6308117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BF3059D42242344A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5053E9A111C50A713770F6757B75AC0274F X-C1DE0DAB: 0D63561A33F958A581C1AFEC71672353B12C505D21E772478517543CAA05BE97D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA8975497C7004E8EB7818E4460D8C3D1DAF66A9F2FF7ACED69152EFE2E3FAE54980C73628C7E2B11D7E09C32AA3244C41D028DD33EA3C10898B58B40E05E78C795D98D676DD64D0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW1gTze7rQD08g== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DB0ACB1F08CEF344D3AE4173B62D426EEA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! The changes are fine, so no comments regarding them, but please consider the nit regarding the commit message. On 20.07.21, Maxim Kokryashkin wrote: > Backports 'supoort Tarantool' patch[1] from lua-Harness. Please, describe the changes in details. E.g. it's worth to mention that this patch introduces lua-Harness profile for Tarantool considering the platform specifics. Furthermore, these changes skips all CLI-related tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be renamed back. > > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16 > > Part of tarantool/tarantool#5970 > Part of tarantool/tarantool#4473 > --- > ...standalone.t.disabled => 241-standalone.t} | 5 ++ > test/lua-Harness-tests/320-stdin.t | 2 +- > .../{411-luajit.t.disabled => 411-luajit.t} | 2 +- > test/lua-Harness-tests/profile_tarantool.lua | 63 +++++++++++++++++++ > 4 files changed, 70 insertions(+), 2 deletions(-) > rename test/lua-Harness-tests/{241-standalone.t.disabled => 241-standalone.t} (99%) > rename test/lua-Harness-tests/{411-luajit.t.disabled => 411-luajit.t} (99%) > create mode 100644 test/lua-Harness-tests/profile_tarantool.lua > > -- > 2.32.0 > -- Best regards, IM