From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 213BB6EC55; Mon, 26 Jul 2021 00:32:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 213BB6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627248737; bh=uxoqhZUi3ZTSL+658q+kLUngueAmpQ5TEns0kUTA52M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pmSbEcRDTVEUExL8+SV6UdXqYrVgFdMnE2m6ehJ79DsSMg8PDnVEeMg9w1DVFtz3S NB17SSBIpI7mhoOzYX272QMbFD6vpr9nSIlzZuCnKX864dQPOIl1nrGzTVW2710qSj 5t0QAB0q/b+IOQgi27/zQUM/77ORPTD1Y69O/KTw= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3BDBF6EC55 for ; Mon, 26 Jul 2021 00:32:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3BDBF6EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m7ljK-0001hI-04; Mon, 26 Jul 2021 00:32:14 +0300 Date: Mon, 26 Jul 2021 00:08:38 +0300 To: Maxim Kokryashkin Message-ID: <20210725210838.GC27855@tarantool.org> References: <3fc0b9e1c18be73ceabe85e41818b0a4ee3e2102.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3fc0b9e1c18be73ceabe85e41818b0a4ee3e2102.1626797225.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3FDAB68B812060C77E621B90589399EB5182A05F5380850403262041792BC03BD0058ED2924591E6FC5582EBE3B4E4B385A21F28D95D61152 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7353CFE866E745C13EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DAE863916B47044D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85719593F4B9D8ADB6ED70AB48A41B6F7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CDDB9BF3B882869D543847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5053E9A111C50A713773FDE802C51FDE179 X-C1DE0DAB: 0D63561A33F958A5FD37298F949EE188494774F96E714233E28EDDB469513EE9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349FF8F8245A2FAA7BCF9C9CEACFFF404603E5570021D88C3CE3ADAA58E28AB74E6797CE1CC49145851D7E09C32AA3244CAD9F86FDF18AB7834A817ED935D853FD7101BF96129E4011927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW1CP2uUegXkkQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DD5E6D897AAAEB862B3D9008CCB81E7F2A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM, except the several nits. On 20.07.21, Maxim Kokryashkin wrote: > Backports conversion to Test.Assertion patch[1] from lua-Harness suite Typo: Dot is missing at the end of the sentence. > > As a result out of this change out-of-source testing is broken, but the Typo: s/As a result out of/As a result of/. > previous assertion using package.path as a second argument worked fine. > Because of that, this commit includes fix, that was made by this patch[2] > in mainline lua-Harness. > > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/074fefa51da1276078f735fa8fb568963fe541f1 > [2]: https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe06fcdc0d83a72dfa56eaae3ed26151c04 Minor: You can strip commit hash in the links above up to 7 symbols to shorted them a bit. Feel free to ignore. > > Part of tarantool/tarantool#5970 > Part of tarantool/tarantool#4473 > --- > Additional comments on issue with out-of-source testing: > https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605 > > test/lua-Harness-tests/090-tap.t | 8 +- > test/lua-Harness-tests/091-profile.t | 10 +- > test/lua-Harness-tests/101-boolean.t | 126 +-- > test/lua-Harness-tests/102-function.t | 218 ++--- > test/lua-Harness-tests/103-nil.t | 126 +-- > test/lua-Harness-tests/104-number.t | 270 +++---- > test/lua-Harness-tests/105-string.t | 308 ++++---- > test/lua-Harness-tests/106-table.t | 132 ++-- > test/lua-Harness-tests/107-thread.t | 128 +-- > test/lua-Harness-tests/108-userdata.t | 124 +-- > test/lua-Harness-tests/200-examples.t | 12 +- > test/lua-Harness-tests/201-assign.t | 82 +- > test/lua-Harness-tests/202-expr.t | 138 ++-- > test/lua-Harness-tests/203-lexico.t | 66 +- > test/lua-Harness-tests/204-grammar.t | 76 +- > test/lua-Harness-tests/211-scope.t | 24 +- > test/lua-Harness-tests/212-function.t | 138 ++-- > test/lua-Harness-tests/213-closure.t | 32 +- > test/lua-Harness-tests/214-coroutine.t | 96 +-- > test/lua-Harness-tests/221-table.t | 54 +- > test/lua-Harness-tests/222-constructor.t | 34 +- > test/lua-Harness-tests/223-iterator.t | 18 +- > test/lua-Harness-tests/231-metatable.t | 232 +++--- > test/lua-Harness-tests/232-object.t | 38 +- > .../241-standalone.t.disabled | 116 +-- > test/lua-Harness-tests/242-luac.t | 80 +- > test/lua-Harness-tests/301-basic.t | 748 +++++++++--------- > test/lua-Harness-tests/303-package.t | 119 +-- > test/lua-Harness-tests/304-string.t | 648 +++++++-------- > test/lua-Harness-tests/305-utf8.t | 4 +- > test/lua-Harness-tests/306-table.t | 186 ++--- > test/lua-Harness-tests/307-math.t | 266 +++---- > test/lua-Harness-tests/308-io.t | 248 +++--- > test/lua-Harness-tests/309-os.t | 158 ++-- > test/lua-Harness-tests/310-debug.t | 226 +++--- > test/lua-Harness-tests/311-bit32.t | 70 +- > test/lua-Harness-tests/314-regex.t | 8 +- > test/lua-Harness-tests/320-stdin.t | 26 +- > test/lua-Harness-tests/401-bitop.t | 60 +- > test/lua-Harness-tests/402-ffi.t | 78 +- > test/lua-Harness-tests/403-jit.t | 96 +-- > test/lua-Harness-tests/404-ext.t | 162 ++-- > test/lua-Harness-tests/411-luajit.t.disabled | 166 ++-- > test/lua-Harness-tests/lexico52/lexico.t | 22 +- > test/lua-Harness-tests/lexico53/boolean.t | 44 +- > test/lua-Harness-tests/lexico53/function.t | 72 +- > test/lua-Harness-tests/lexico53/lexico.t | 14 +- > test/lua-Harness-tests/lexico53/nil.t | 44 +- > test/lua-Harness-tests/lexico53/number.t | 224 +++--- > test/lua-Harness-tests/lexico53/string.t | 196 ++--- > test/lua-Harness-tests/lexico53/table.t | 44 +- > test/lua-Harness-tests/lexico53/thread.t | 44 +- > test/lua-Harness-tests/lexico53/userdata.t | 44 +- > test/lua-Harness-tests/lexico53/utf8.t | 240 +++--- > test/lua-Harness-tests/lexico54/lexico.t | 8 +- > test/lua-Harness-tests/lexico54/metatable.t | 14 +- > test/lua-Harness-tests/lexico54/utf8.t | 34 +- > test/lua-Harness-tests/lexicojit/basic.t | 14 +- > test/lua-Harness-tests/lexicojit/ext.t | 26 +- > test/lua-Harness-tests/lexicojit/lexico.t | 30 +- > test/lua-Harness-tests/tap.lua | 96 ++- > 61 files changed, 3599 insertions(+), 3566 deletions(-) > > -- > 2.32.0 > -- Best regards, IM