From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E93676EC55; Mon, 26 Jul 2021 00:27:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E93676EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627248446; bh=1nNSfmGwgumQKnV1VUjWx+94KI0gST6q/JVPEzxylB4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nyr17x49vlxexdZbSGnhOMYGrkO3Y+XMbJV56WaYKkFcCrfL6MyxPVfNoe8cPTUrc Eb8Dp+5Bh2rXTN4ql4JT6ujt1aJJQJVFbEdOkLUAo5Gsu7Sqba2vpJUaUpM5zUbRk9 xrrJxKhquBT8ViUs283ghx3inU51z7YtaiVrQzP4= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B0CEE6EC55 for ; Mon, 26 Jul 2021 00:27:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B0CEE6EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m7lec-0007jt-Aq; Mon, 26 Jul 2021 00:27:22 +0300 Date: Mon, 26 Jul 2021 00:03:46 +0300 To: Maxim Kokryashkin Message-ID: <20210725210346.GB27855@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30A5AB0699C09BB51962E4FF0DD431C8A182A05F538085040EC45A898CC85C6116E37F28B9D6DE6B94AF18B03EBDFB4522F1606ECE0D6C898 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DBA72CFE7C57007CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375C4806A08D329A618638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8873601AC1FDFBBEA7B9B76CFCEA60762117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CDDB9BF3B882869D543847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5053E9A111C50A713773DCDD90AEBD89344 X-C1DE0DAB: 0D63561A33F958A526B31D6F10B2678FC440DF20D43C62B40B3F8F942121AD4CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340B06C327CE4A70E81DAA6989FDDF5AF3F6D431208DC6876DF5E105B5603D92D0FB16580F54A5AA381D7E09C32AA3244C4BCC4239C82FAB40B2C3A1388246D577435BF7150578642F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW2AQBvcp8cROA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D01094A81F3771C695B203598C94F956FA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the series! Please consider the comments I left for each patch. Besides, to differ the patches for tarantool/tarantool repo from the patches for tarantool/luajit repo, please use 'luajit' in subject prefix when formatting the patch (consider this patch[1] as an example). On 20.07.21, Maxim Kokryashkin wrote: > As our experience has been considered by the maintainer of lua-Harness > and the issues we faced are finally fixed in mainline repo, we should > bump lua-Harness suite up to c4451fe0. > > Part of tarantool/tarantool#5970 > Part of tarantool/tarantool#4473 > > --- > Changes in v2: > - Fixed comments as per review by Igor Munkin > - Backported two more fixes from trunk > - Disabled 241-standalone.t as it is facing some issues to run > properly on FreeBSD (for more information see > tarantool/tarantool#6231) > > Github branch: > https://github.com/tarantool/luajit/tree/fckxorg/gh-5970-update-lua-harness > > Issue: > https://github.com/tarantool/tarantool/issues/5970 > > Tests: passing It's more convenient to share the commit that triggered Tarantool CI. In your case this is https://github.com/tarantool/tarantool/commit/344c18d. > > > Maxim Kokryashkin (10): > test: port lua-Harness to Test.Assertion > test: rename lua-Harness tap to test_assertion > test: use CI friendly variables in lua-Harness > test: refactor with _retrieve_progname > test: refactor with _dofile > test: support tarantool in lua-Harness > test: backport lua-Harness directory detection > test: support tarantool cli in lua-Harness > test: update lua-Harness to b7b1a9a2 > test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD > > test/lua-Harness-tests/090-tap.t | 10 +- > test/lua-Harness-tests/091-profile.t | 12 +- > test/lua-Harness-tests/101-boolean.t | 130 +-- > test/lua-Harness-tests/102-function.t | 222 +++--- > test/lua-Harness-tests/103-nil.t | 130 +-- > test/lua-Harness-tests/104-number.t | 274 +++---- > test/lua-Harness-tests/105-string.t | 312 ++++---- > test/lua-Harness-tests/106-table.t | 136 ++-- > test/lua-Harness-tests/107-thread.t | 132 +-- > test/lua-Harness-tests/108-userdata.t | 128 +-- > test/lua-Harness-tests/200-examples.t | 16 +- > test/lua-Harness-tests/201-assign.t | 84 +- > test/lua-Harness-tests/202-expr.t | 140 ++-- > test/lua-Harness-tests/203-lexico.t | 78 +- > test/lua-Harness-tests/204-grammar.t | 78 +- > test/lua-Harness-tests/211-scope.t | 26 +- > test/lua-Harness-tests/212-function.t | 140 ++-- > test/lua-Harness-tests/213-closure.t | 34 +- > test/lua-Harness-tests/214-coroutine.t | 98 +-- > test/lua-Harness-tests/221-table.t | 56 +- > test/lua-Harness-tests/222-constructor.t | 36 +- > test/lua-Harness-tests/223-iterator.t | 20 +- > test/lua-Harness-tests/231-metatable.t | 236 +++--- > test/lua-Harness-tests/232-object.t | 40 +- > test/lua-Harness-tests/241-standalone.t | 330 ++++++++ > .../241-standalone.t.disabled | 269 ------- > test/lua-Harness-tests/242-luac.t | 88 +- > test/lua-Harness-tests/301-basic.t | 754 +++++++++--------- > test/lua-Harness-tests/303-package.t | 125 +-- > test/lua-Harness-tests/304-string.t | 650 +++++++-------- > test/lua-Harness-tests/305-utf8.t | 10 +- > test/lua-Harness-tests/306-table.t | 188 ++--- > test/lua-Harness-tests/307-math.t | 268 +++---- > test/lua-Harness-tests/308-io.t | 252 +++--- > test/lua-Harness-tests/309-os.t | 164 ++-- > test/lua-Harness-tests/310-debug.t | 230 +++--- > test/lua-Harness-tests/311-bit32.t | 72 +- > test/lua-Harness-tests/314-regex.t | 12 +- > test/lua-Harness-tests/320-stdin.t | 40 +- > test/lua-Harness-tests/401-bitop.t | 64 +- > test/lua-Harness-tests/402-ffi.t | 82 +- > test/lua-Harness-tests/403-jit.t | 100 +-- > test/lua-Harness-tests/404-ext.t | 168 ++-- > test/lua-Harness-tests/411-luajit.t | 211 +++++ > test/lua-Harness-tests/411-luajit.t.disabled | 211 ----- > test/lua-Harness-tests/CMakeLists.txt | 5 - > test/lua-Harness-tests/lexico52/lexico.t | 22 +- > test/lua-Harness-tests/lexico53/boolean.t | 44 +- > test/lua-Harness-tests/lexico53/function.t | 72 +- > test/lua-Harness-tests/lexico53/lexico.t | 14 +- > test/lua-Harness-tests/lexico53/nil.t | 44 +- > test/lua-Harness-tests/lexico53/number.t | 224 +++--- > test/lua-Harness-tests/lexico53/string.t | 196 ++--- > test/lua-Harness-tests/lexico53/table.t | 44 +- > test/lua-Harness-tests/lexico53/thread.t | 44 +- > test/lua-Harness-tests/lexico53/userdata.t | 44 +- > test/lua-Harness-tests/lexico53/utf8.t | 240 +++--- > test/lua-Harness-tests/lexico54/lexico.t | 8 +- > test/lua-Harness-tests/lexico54/metatable.t | 14 +- > test/lua-Harness-tests/lexico54/utf8.t | 34 +- > test/lua-Harness-tests/lexicojit/basic.t | 14 +- > test/lua-Harness-tests/lexicojit/ext.t | 26 +- > test/lua-Harness-tests/lexicojit/lexico.t | 30 +- > test/lua-Harness-tests/profile_ravi.lua | 4 +- > test/lua-Harness-tests/profile_tarantool.lua | 63 ++ > .../{tap.lua => test_assertion.lua} | 133 +-- > test/luajit-test-init.lua | 2 + > 67 files changed, 4165 insertions(+), 4012 deletions(-) > create mode 100755 test/lua-Harness-tests/241-standalone.t > delete mode 100755 test/lua-Harness-tests/241-standalone.t.disabled > create mode 100755 test/lua-Harness-tests/411-luajit.t > delete mode 100755 test/lua-Harness-tests/411-luajit.t.disabled > create mode 100644 test/lua-Harness-tests/profile_tarantool.lua > rename test/lua-Harness-tests/{tap.lua => test_assertion.lua} (58%) > > -- > 2.32.0 > [1]: https://lists.tarantool.org/tarantool-patches/5fdb4899061156f0fb4c53027d55f93be3a24759.1627144350.git.imun@tarantool.org/T/#u -- Best regards, IM