From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 062C86EC40; Wed, 7 Jul 2021 13:08:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 062C86EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625652518; bh=Y04UYQNfiTvlJuM7FAuij8ARnh1e+CVdT2oTwzsxiKg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hGyK39MHRFyoH0YyzkOPbJEASR0QnFW4QuG5rXmdM2l5NVicw3vPbtTKawGKB0p+o amHcD98/YaUIHGeDPbiBHQiZ3eRP67SKNhB6nvSh0tN0jnXSYGGRg1b7N5KLrOVSh2 tgmrWt0hPGUQGOeauY5fbM/8+v0Rww0Hm4ptRGUQ= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C11856EC40 for ; Wed, 7 Jul 2021 13:08:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C11856EC40 Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1m14Tr-0003LI-Kv; Wed, 07 Jul 2021 13:08:36 +0300 Date: Wed, 7 Jul 2021 13:08:09 +0300 To: Vladislav Shpilevoy , Cyrill Gorcunov , Roman Khabibov Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210707100809.nflftsb47hq66efn@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FBE6C6848F3EB6EB89AE0756428E32ECE9182A05F538085040F7C6CB28092D0C28F95FCE8E0F5D55E74264026E2DD5B28C4B0543FBEB3BB8A5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7747FD4AFDBA6C67AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BB46061768088B55EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F20A345B3D94AC36D19285CACF76892C20CC7F00164DA146DAFE8445B8C89999728AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8724336BCC0EE1BA8F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CEB7D890E3377C531302FCEF25BFAB3454AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3FF13C91C9B60D64ABA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE79E9721B410A3B6ED731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58ADD38C256A91A00FBC8A079171FB9833B096E23C8C8EA99D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342B1F2AD168155B06BC1D9438D7E682F5B00243B88F32DED5EB33D087628B53B9492D25A8A7C8B3041D7E09C32AA3244CC3224255A532ED1DE8991A77AB9F8A8460759606DA2E136A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwWhFrYo6Pn3h7FL2kRs+Eg== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE2A566B00096E86E65B5647E923FB1308B7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/4] RFC: Isolate serializer helpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jun 23, 2021 at 10:12:38PM +0300, Alexander Turenko wrote: > Moved the serializer helpers into its own compilation unit, add some > comments and a basic test: everything is just to simplify diving into > this code. > > Guys, please, look, whether it seems useful enough to include into > tarantool's mainline? Should we name it serializer.[ch] or > somehow like serializer_helpers.[ch]? > > Part of https://github.com/tarantool/tarantool/issues/3228 > Branch: Totktonada/gh-3228-extract-serializer-helpers > > Alexander Turenko (4): > lua: move serializer helpers into its own file > lua: move luaL_newserializer() comment into header > lua: split serializer functions into sections > test: add a basic unit test for serializer helpers Thanks for reviews! Pushed to master, 2.8, 2.7. I'll backport it to 1.10 and show you first. WBR, Alexander Turenko.