From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2A0CE6EC40; Tue, 6 Jul 2021 23:53:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2A0CE6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625604791; bh=yZzvCn+QzcEu9FSv7Xn9ZvDJBH/p2msfOa3YtK9Yhoo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KT2zzwY1kuXxM4dshPbigM51oIx8a9396K4OIah+tTc4LcnUzVjA+GtaJ93YXWgfE PIkBNG+sXP8TNWmy2uA4HcYAXN3HLrBQNLg86c4VU9M4Y+R8Mfh0raQeHKvCdv4c14 GDwufTbUcUmXk8M99B3MzL9p717zsEBYLSvuXAKo= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7EA2B6EC40 for ; Tue, 6 Jul 2021 23:52:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7EA2B6EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m0s3q-0003rz-H0; Tue, 06 Jul 2021 23:52:54 +0300 Date: Tue, 6 Jul 2021 23:29:23 +0300 To: Maxim Kokryashkin Message-ID: <20210706202923.GB11494@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB0C620705B15DE32DFE392EA95FA71EAB182A05F538085040FDD947EE82DF58CF555BEE4BB15D97990E5751EDD43D2BA988BCCBA7670A8049 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370AEA98ADD099B586EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2AC8A7486973AACE85A3AA752CE67E329CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC821E93C0F2A571C7BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B569F1129A2C6445075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5BE2BAD05C4C6A88515FD019ECC73ECA7F2E598D87EA2AA0CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75342909995EBBA6E4410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BC3EEE75EF3BACCF3AFA088CE0994842A48CF3F7BBF5AE9A7321184F5709495036F23F7A7FA8028E1D7E09C32AA3244C508B3D7959D5C97701D4C095F2380839B038C9161EF167A1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwWhFrYo6Pn3riIHziqKldw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D645AC0BA562C64A5D0763CF9219B39CBA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/4] test: resolving program name X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! I left several comments below, please consider them in addition to the main comments in the cover letter. On 05.07.21, Maxim Kokryashkin wrote: > From: Maxim Kokryashkin > > Part of tarantool/tarantool#5970 > --- > The patch `fperrad/lua-Harness@1be25a8` from lua-Harness suite is the > same as the patch `tarantool/luajit@8376885`, except for We use the different scheme to mention the particular patch. * If this is the patch from this repository, then we just use 40-digit hash + commit subject enclosed in a single quotes and parenthesis. E.g. 837688590919fcf8de47ef90479fd2a640c8fddc ('test: adjust lua-Harness suite to CMake machinery'). * If this is the patch from another repository, we just use the full link. For the link in plain text (i.e. commit message) we use the next policy: [] + []: at the end. E.g. this commit[1] links to this particular patch pushed to our LuaJIT fork (look for the link at the end of the message). > `get_lua_binary_name()`, which was renamed to `_retrieve_progname()` > in `fperadd/lua-Harness`. It also worth to mention the patch, where is introduced, since the original patch in lua-Harness differs from yours one. Considering everything written above, I propose the following rewording for commit message: | The patch[1] from lua-Harness suite fixes the same issue commit | 837688590919fcf8de47ef90479fd2a640c8fddc ('test: adjust lua-Harness | suite to CMake machinery') does except the single difference: | `get_lua_binary_name()` is called `_retrieved_progname()`. As a result | of this patch the function is renamed to follow the original naming. | | [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8 | | Part of tarantool/tarantool#5970 | Part of tarantool/tarantool#4473 If you are OK with the part above, feel free to paste it as is into the commit message for the next version of the patch. One more comment: I see Sergey confused you with his review. As it was mentioned in the previous review, the patch "body" is splitted into two parts by three dashes ('---'). * The part above is the commit message and it should contain only the polished description of the patch (in other words, everything you have written before my comment). * The part below is your blackboard/canvas/etc: you can put there any supplementary or auxiliary information, such as branch name (missing both here and in the cover letter), link to the issue (also missing), test results (also missing). > > test/lua-Harness-tests/241-standalone.t.disabled | 2 +- > test/lua-Harness-tests/242-luac.t | 2 +- > test/lua-Harness-tests/301-basic.t | 2 +- > test/lua-Harness-tests/308-io.t | 2 +- > test/lua-Harness-tests/309-os.t | 2 +- > test/lua-Harness-tests/320-stdin.t | 2 +- > test/lua-Harness-tests/411-luajit.t.disabled | 2 +- > test/lua-Harness-tests/tap.lua | 8 ++++++++ > 8 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/test/lua-Harness-tests/tap.lua b/test/lua-Harness-tests/tap.lua > index a8454ae0..86cca4e0 100644 > --- a/test/lua-Harness-tests/tap.lua > +++ b/test/lua-Harness-tests/tap.lua > @@ -9,6 +9,14 @@ > > ]] > > +function _retrieve_progname () > + local i = 0 > + while arg[i] do > + i = i - 1 > + end > + return arg[i + 1] > +end Please also remove within this patch. > + > if pcall(require, 'Test.More') then > diag 'Test.More loaded' > return > -- > 2.31.1 > [1]: https://github.com/tarantool/luajit/commit/d377115 -- Best regards, IM