From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 57B136EC40; Tue, 29 Jun 2021 19:21:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 57B136EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624983678; bh=3MU3zFzs2Bkwb8Hd51AIQEiLh3uzwAhKuY4ppRr186Q=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sVQMr0hgATAlmxbrdH/7qLv+TZ+fg9BFgg70hKStKQq8gRKVX7Wc/VNCRwai43E1V HTUOQGuIhlWmt5bNoGSDybBrbDGZY9AuQtI0gQ4lkxnzHJS/SEyMgFfsk5LVb/pnC1 hRUaegARI7nyzn934J/D+Nx2JpPqBFMrPLNtv51Q= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 284BA6EC40 for ; Tue, 29 Jun 2021 19:21:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 284BA6EC40 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lyGU7-0001eK-Uk; Tue, 29 Jun 2021 19:21:16 +0300 Date: Tue, 29 Jun 2021 19:21:05 +0300 To: Timur Safin Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20210629162105.GD10212@tarantool.org> References: <20210620185759.GC10212@tarantool.org> <151601d76baa$6d360c70$47a22550$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <151601d76baa$6d360c70$47a22550$@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB0C620705B15DE32DFE392EA95FA71EAB182A05F5380850400A892BD30BE494C4AD6F82A9BF9DB4B3EF353BB065D9E9B0EF6E1B38289DF5B2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75DF2B1F23425CAE5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372E9841F416E2DCCD8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84EFA8752A4EDA38CD7D0D93B0874F2FE117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B658CDF7FFE3EBBCC0089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A528D4DC503B93899464DA13181208FADCB927FDAC79547704D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D6AC337C1E637B8AF75DBCC42AF9E7065B478B6CB3A709877E03A74567176D4409976006D3903E991D7E09C32AA3244C28311000681EF0A44263A3AB7A1D2204259227199D06760A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNjLyMoNI2JbDdDI2G9MQkQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F58A82866038B300C929A6BE50DCCC92A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Timur, On 28.06.21, Timur Safin wrote: > > : From: Igor Munkin > : Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported > : error lines > : > : Timur, > : > : Thanks for the patch! Though the change is quite trivial, the patch is > : not OK right from the top. Please adjust the commit subject according to > : our contribution guidelines[1]. > > Much thanks Sasha for his useful proposal, not thanks to Igor for useless > referring to guidelines without suggestion. Sorry, my bad. If you need a suggestion, here you are: re-read our contribution guidelines, especially the following bullet: | Use the imperative mood in the subject line. A properly formed Git | commit subject line should always be able to complete the following | sentence: "If applied, this commit will /your subject line here/". > > : > : Minor: Strictly saying :123 part is also broken. > > O_o, why? Could you please clarify? We report it as line number in the > source file, in this case tkt-9a8b09f8e6.test.lua:123 was exactly the > caller location? Do you need the location of definition (:123) or location where the function execution is stopped at the moment (:142)? If I got your point, you prefer the latter, right? > > : > diff --git a/src/lua/tap.lua b/src/lua/tap.lua > : > index 346724d84..77fd8d096 100644 > : > --- a/src/lua/tap.lua > : > +++ b/src/lua/tap.lua > : > @@ -23,7 +23,7 @@ local function traceback(level) > : > local frame = { > : > source = info.source; > : > src = info.short_src; > : > - line = info.linedefined or 0; > : > + line = info.currentline or info.linedefined or 0; > : > : Why did you leave such a complex code here? I believe you can use just > : info.currentline here. > > Just in case :) Nice reasoning :) > if currentline may be missing in the traceback object for any reason. It may not, considering the flags used for obtaining debug info. > If it's impossible for the set of requested flags, then I'll get rid > of linedefined here. Yes, field is provided by 'l' flag[1]. Please, get rid of and the default 0 and drop a few sentences regarding this change in commit message. > > : : [1]: : > https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/#how- > : to-write-a-commit-message : : -- : Best regards, : IM > > Thanks, Timur > [1]: https://www.lua.org/manual/5.1/manual.html#lua_getinfo -- Best regards, IM