From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 59FB56EC55; Fri, 11 Jun 2021 18:23:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 59FB56EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623424985; bh=L3aPr5rRrrVpRmmL743gdHfEsdM0h2yau787zLN5U60=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=fG03SMIzVGECCW6KiVDlZDHTPB9AcDoq6YIo8SHM7yO7nErZesjUN5AtWFzzF+oXJ BFKMODtYyLZyyc1TvWlJHE8NhhSiCsxooR1ktt04MhoqaGC/5728FFkMjBlSHDyZ05 X0Ri7IPXtpDYXt7BWmU4L+01bps0XBK+XCmtJAlk= Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7C0FE6EC55 for ; Fri, 11 Jun 2021 18:23:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7C0FE6EC55 Received: by mail-lf1-f43.google.com with SMTP id a1so9066623lfr.12 for ; Fri, 11 Jun 2021 08:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q5lWxr/CC32qBe6T1gYG/jFkEp/7BrPK1hDvwPHJTgs=; b=ppYgGBs/zdIWFus02JnyLFfV1/EisHawstnkIrG3sLyDP56BY+fOih7XWavBa/R/P5 c3U4+HfK5APY1YqpIe8yFXTs0PIlwS1O37IYz5FGFHWwh/Y3WB+x+W+gBfTHzSRrtA8B XUrmk+nlvdW+18LAEgTgXz9xId/4Y7HG8fxzbKsdu8TmBu4WUFfnbhfJP838upGdBDnQ y89GtF0g8V4CXK2EpKty5AAMsPxmeJ+RIVJIewid0N0aNK9n6YLkRXGMVgCsPWupDVPP egtssDg0CBakePE1MOtFKY7x4eV+XBWcAu7wI7pJlIoBx90WrjXwhAXrKkHA+YnUC6qv A2zg== X-Gm-Message-State: AOAM533bVufh7+/KMEI1WjrsEO8ZIfuQviXg1HfOHsDZApYj8XzWamzS hWj6fUmXinLgnbZzknL9StxzrAofHaY= X-Google-Smtp-Source: ABdhPJzuq/k+I4IS11o2ND/0Gf5T9uPOfa5BaGvsryLucOHry3owxJUqoMRru1mTc/xvyRbkExxpFQ== X-Received: by 2002:ac2:5978:: with SMTP id h24mr3082829lfp.232.1623424982168; Fri, 11 Jun 2021 08:23:02 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id q126sm751534ljq.111.2021.06.11.08.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 08:23:01 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 4281F5A0041; Fri, 11 Jun 2021 18:23:00 +0300 (MSK) To: tml Date: Fri, 11 Jun 2021 18:22:57 +0300 Message-Id: <20210611152259.205627-1-gorcunov@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v8 0/2] filter incoming packets X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Guys, here is a patch which implements the filtration we are interested in. The patch is not for merging yet because there some weird things going on: - to verify that we're hitting exactly the issue we're interested in I apply Vlad's patch to make sure that replication doesn't pass where is should - the test sets up somehow weird configuration but changing it even a bit doesnt trigger the problem we're investigating, and to be honest I'm not sure why - current test (with Vlad's patch applied) returns box.space.sync:select{} | --- | - [] | ... in turn if we revert Vlad's patch then data get propagated to replica1 as it should, which proves that we need to filter by xrow->replica_id Still I would like to get a feedback how to simplify the testcase. branch gorcunov/gh-6035-applier-filter-7-notest Cyrill Gorcunov (2): applier: filter incoming synchro packets via transaction initiator Vlad: applier filtration src/box/applier.cc | 29 ++-- src/lib/raft/raft.h | 7 - .../gh-5445-leader-inconsistency.result | 15 ++ .../gh-5445-leader-inconsistency.test.lua | 5 + .../replication/gh-6035-applier-filter.result | 137 ++++++++++++++++++ .../gh-6035-applier-filter.test.lua | 64 ++++++++ test/replication/gh-6035-master.lua | 1 + test/replication/gh-6035-node.lua | 35 +++++ test/replication/gh-6035-replica1.lua | 1 + test/replication/gh-6035-replica2.lua | 1 + test/replication/suite.cfg | 3 + 11 files changed, 278 insertions(+), 20 deletions(-) create mode 100644 test/replication/gh-6035-applier-filter.result create mode 100644 test/replication/gh-6035-applier-filter.test.lua create mode 120000 test/replication/gh-6035-master.lua create mode 100644 test/replication/gh-6035-node.lua create mode 120000 test/replication/gh-6035-replica1.lua create mode 120000 test/replication/gh-6035-replica2.lua base-commit: 9fb95cfd78403b33cacbe765c35036a0532b2c02 -- 2.31.1