From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 07E4E6EC55; Thu, 10 Jun 2021 19:40:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 07E4E6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623343254; bh=SpUyr2Y84+Hqc34Z5igil3OsT5M3sHJNlCUhoCmubq4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iEkzgqSYMUrS6tChTYHwQMjs2DSdAT+uPYSRk81R0jKdBO6UgdejmlxYtREdFL8br fr3jlTyba4cwpLG/oyaYF+R/YctnGQLtizJPZUgI7ZRFmG/6PgJaHCI8qH0EudzpNx jxbq2SpzhnDQjwxSosaCpoHpdy2KsGsNBGEZWFas= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D5BDB6EC55 for ; Thu, 10 Jun 2021 19:40:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D5BDB6EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lrNjf-0008Vw-Io; Thu, 10 Jun 2021 19:40:52 +0300 Date: Thu, 10 Jun 2021 19:40:45 +0300 To: Sergey Kaplun Message-ID: <20210610164045.GB3944@tarantool.org> References: <20210602155958.16322-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210602155958.16322-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C540E30C2BDD69416C6E46C178CD572CB10182A05F53808504018B9C8B27B6976BC7E122E3E529C635B5BB4A7D3B2066AA6216EF433808AEA16 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376D321F80F15DC2F18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CEA16F7AFEF21038B5E57D013F218188117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5660B065FA18769A13789FC58124E64177E5D796A28D8A3ADD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A783A638E01A3CDE1264F388EEC6B9CC03A2021A01C4A9300B21FFAE0475C283685DADA5B3EDED2F1D7E09C32AA3244C94667E10F5019B83E9F9D796B93D6F21C3B3ADDA61883BB5927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCpYK6nkTlbEbuC9VWSwSpg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822733DFCD469CEA1499108BE023DAE7F05A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: fix debug flags for LuaJIT assertions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! Please consider the nits below. Otherwise, LGTM. On 02.06.21, Sergey Kaplun wrote: > This patch fixes inaccuracy in Tarantool build configuration introduced > by commit 07c83aa ('build: adjust Typo: Please use the full hash. > LuaJIT build system'). That patch sets LUAJIT_USE_ASSERT and > LUAJIT_USE_APICHECK options for Debug build instead LUA_USE_ASSERT and Typo: s/instead LUA_USE_ASSERT/instead of LUA_USE_ASSERT/. > LUA_USE_APICHECK correspondingly. This patch fixes these typos. Minor: s/correspondingly/respectively/. > > Follows up #4862 > --- > > Branch: https://github.com/tarantool/tarantool/tree/skaplun/tarantool-debug-fix > > > Also, LUAJIT_USE_ASAN -- is set, but LuaJIT checks for ENABLE_ASAN as > is with corresponding FIXME to implement ASAN correctly. But it > looks like it should be done in a separate patch by enabling all LuaJIT > build flags, see list of options here [1]. BTW, we have a separate issue for enabling ASAN in LuaJIT[1]. > > [1]: https://lists.tarantool.org/tarantool-patches/20210211192336.GC9361@root/ > > cmake/luajit.cmake | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > -- > 2.31.0 > [1]: https://github.com/tarantool/tarantool/issues/5878 -- Best regards, IM