From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D1A856EC55; Thu, 10 Jun 2021 16:52:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D1A856EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623333179; bh=oJCxmT/GuNQNn99VGL3T+8HXCkG3vetnV3pJi1kuwu4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NyUjDT0SXOGwH1h4folwvByW8/uw7dyv5uuYusKzZNfNd/YvghBHoQ0d+WcC1wH2d vxxQmhPzAvaqrKGCEkNrpUp+7l5f+3p2oLECl7kE6hESTdfbV/i0YzRiS8XRmXsfQ6 mO2zz3eRTnF9V9ZfTsJQgZg72EZe5LOvn/ye4ZFY= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2A8666EC55 for ; Thu, 10 Jun 2021 16:52:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2A8666EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lrL73-00018g-7Y; Thu, 10 Jun 2021 16:52:49 +0300 Date: Thu, 10 Jun 2021 16:52:43 +0300 To: Sergey Kaplun Message-ID: <20210610135243.GA3944@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54907A7AE9C1BA82BC67C1327DFB87C6A6182A05F538085040510E45BE43745142CC82C7654E29CE47B6FA1A872EB9E0E0B523D5F81CF86D7A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7081BBE264C6D7F42EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BB46061768088B55EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D4049B0B9C99C0AC72F683DE43EC814B867FCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9EB32FE0C26A3A4C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783194B8732D048B9BDA437CCAE968C07DD4 X-C1DE0DAB: 0D63561A33F958A531D1E528D0820289BBF71229B6A9C27965C2E607CA77D0AAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340297C696F996E384025D2849F54ED5830744F98CEA73BB2BFC056216BD025CA92CBA8B415BFD32481D7E09C32AA3244C51FA6CFD64FDEA65AEDDFC44B3FA7AAD9CA7333006C390A0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCpYK6nkTlbHuT98bIBaDOQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822343CE66ACE4803F7190CD2A7E76C7BDDA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/4] ARM64: Fix xpcall() error case (really). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! There are still typos left after fixing Sergos review comments (the commit message is taken from the branch). Otherwise, LGTM. | ARM64: Fix xpcall() error case (really). | | Thanks to François Perrad and Stefan Pejic. | | (cherry picked from commit d417ded17945b4211608d497d50b509e0274f5e0) | | Premature decrement of VM's RC register before switch to fff_fallback | handler during processing `xpcall()` fast function leads to incorrect | stack layout (not enough arguments on stack), when `xpcall()` calls Typo: s/calls/is called/. | without a second argument or if it is not a function (see | Typo: looks like line underfull (in LaTeX terms). | test in lua-Harness test suite). While further error processing it leads | to incorrect error message, due to stack inconsistency. | | This patch stores intermediate result into TMP1 register (it does not | determine fallback's behaviour and there is no way to return from | fallback back to xpcall processing with spoiled TMP1) and moves RC | setting after the switch to the fallback handler. | | Sergey Kaplun: | * added the description for the problem | | Resolves tarantool/tarantool#6093 | Part of tarantool/tarantool#5629 -- Best regards, IM