From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2F6A46EC55; Thu, 10 Jun 2021 16:52:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F6A46EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623333120; bh=6ApTIS7qaPRVDjMZXILuS3SA72YRIVTYI/pEwcDQ5VQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HVflAKcIVkocC7k78HNk7eeRBLbwbhATo63pHliqEWtFryKlchRB53MtZSgROe/w4 r+GkJyJlXPqC2Kej7RmT9hNzpl1r4ibh3kfnOJP7Mla00eLF8wOlXLq+Q+zrDMcn0O 1FG21HNSPm878GLfKhYQSmEa8jGgQ67lSS2Pdh9k= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 298586EC55 for ; Thu, 10 Jun 2021 16:51:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 298586EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lrL67-0001Bl-8t; Thu, 10 Jun 2021 16:51:51 +0300 Date: Thu, 10 Jun 2021 16:51:45 +0300 To: Sergey Kaplun Message-ID: <20210610135145.GY3944@tarantool.org> References: <703b21b49b4f5b04b71b322c25528eff4fb2d0e3.1621859367.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <703b21b49b4f5b04b71b322c25528eff4fb2d0e3.1621859367.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54EECC50CDFE52CD8E09EC742E3E75A787182A05F53808504045C697BE7E8B5404EC11C6D255D723DB9DC557C8BBBB624253EE6CB24F20F7E1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8378C09EF493A02EB2ED893FF6523803E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5C47D83EE3B2EAD868103F141D49D8C0DD459C7245A4CB17ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3467D08F30473A58424085EBC9262D6AC764E483CC1DE853261B00A22988E38FA1135B08C7020E74201D7E09C32AA3244C8F72C1729304E4F25016E71AC5F356EBBBA718C7E6A9E042927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCpYK6nkTlbHNdxlJS3rr1Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822BB646936B6D60C2DB5A746D3D5A3DD46A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] test: add skipcond on architectures for memprof X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! Consider the couple of nits below regarding the commit wording. Otherwise, LGTM. Minor: It's hard to parse the patch subject IMHO. I propose the following rewording: | test: add arch-specific skipcond for memprof On 24.05.21, Sergey Kaplun wrote: > Memprof's tests fail for architectures different from x86 and x64, > because memprof is not yet implemented for them. > > This patch adds skip condition to corresponding test. Typo: s/to corresponding/to the corresponding/. > --- > test/tarantool-tests/misclib-memprof-lapi.test.lua | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index b4d66509..4df9cfd8 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -1,3 +1,9 @@ > +-- Memprof is implemented only for x86 and x64 architectures. > +require("utils").skipcond( > + jit.arch ~= "x86" or jit.arch ~= "x64", Side note: Seen the bunch with the related fixes on the branch. > + jit.arch.." architecture is NIY for memprof" > +) > + > local tap = require("tap") > > local test = tap.test("misc-memprof-lapi") > -- > 2.31.0 > -- Best regards, IM