From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4E06E6EC58; Thu, 27 May 2021 19:40:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E06E6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622133658; bh=npnFqZ5F3rhumNcg0XscH4x/Efih5IbMCUAx4mKJXMY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UAq6nbzdxvqKI6dQrI1E1TawL9HyyXf8Tw1dOjQ1KTtmWgs4Rr524WTntEf7BMtwg iF1cFRL0X8+LvjVXD4PUa8KCbOFgU7ehJ+0r1am3RW+IhhswjuQ+lnIfdo9vWquzLy RZ7T64HniNhyBwm73hfTQy2UoA5PLiA5hBi0x53M= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0FB196EC58 for ; Thu, 27 May 2021 19:40:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0FB196EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lmJ44-0007DR-Bf; Thu, 27 May 2021 19:40:56 +0300 Date: Thu, 27 May 2021 19:40:55 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210527164055.GA324813@tarantool.org> References: <9d53f29d460d7a4194cb3f95de4b5a4016453db3.1621503852.git.imeevma@gmail.com> <2cf25c21-9522-446d-3cf9-d36e0523d24b@tarantool.org> <20210525141313.GA81084@tarantool.org> <67f98969-53b2-52ab-3042-ecb9aef304e1@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <67f98969-53b2-52ab-3042-ecb9aef304e1@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9157EECD0FDB90B9A3C7FC6B53229AFE7CC4D706690F5628300894C459B0CD1B9B83C3108724A6AD38184B92DAAE6FCA0E4C9BF811385D26DD5D5E52AFDF0C1B1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063726CA83C7ABDB938E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85CF92B49BFD17C109FFD1E25B9C6C844117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783145FE5FF2669329D8AE02DBCB839BB422 X-C1DE0DAB: 0D63561A33F958A5D63AEE533810880FAE064FF210E11C1163AB29448667BD71D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75E3127721F5A72C97410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347130F804358653A633FF753484C4269DD90FBABA26CCEEA6FB6CC2C6814021046566B8D5FCF126D71D7E09C32AA3244C2437A81C4A8B78B866755C9F3F9AFC8E1DD47778AE04E04D729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojywAFAsvjBJhT/FGS0KXj2g== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638223711C69BCB2DA160E6EAA209A8C79DF583D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] sql: introduce UUID field type X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the review! My answer and diff below. Also, I plan to send you this patch one more time as part of patch-set, that contains this patch and patch that introduces SQL built-in function uuid(). On Tue, May 25, 2021 at 11:50:45PM +0200, Vladislav Shpilevoy wrote: > Nice fixes! > > > diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c > > index a518fd0c6..9a6689d7d 100644 > > --- a/src/box/sql/mem.c > > +++ b/src/box/sql/mem.c > > @@ -81,6 +91,8 @@ mem_str(const struct Mem *mem) > > case MEM_TYPE_MAP: > > case MEM_TYPE_ARRAY: > > return mp_str(mem->z); > > + case MEM_TYPE_UUID: > > + return tt_sprintf("%s", tt_uuid_str(&mem->u.uuid)); > > You don't need tt_sprintf() either. You need to simply > return tt_uuid_str(). Thanks, fixed. Diff: diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c index 9a6689d7d..2ad104e1b 100644 --- a/src/box/sql/mem.c +++ b/src/box/sql/mem.c @@ -92,7 +92,7 @@ mem_str(const struct Mem *mem) case MEM_TYPE_ARRAY: return mp_str(mem->z); case MEM_TYPE_UUID: - return tt_sprintf("%s", tt_uuid_str(&mem->u.uuid)); + return tt_uuid_str(&mem->u.uuid); case MEM_TYPE_BOOL: return mem->u.b ? "TRUE" : "FALSE"; default: