From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4552A6EC58; Thu, 27 May 2021 01:05:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4552A6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622066702; bh=xbKHI2rDNa+RAS3WRGyr+5riRoTjR6w6G4foPTKsA+4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TxA0VnRdKNLobSXR1c+ucS8FLxKr3NtlZRmBv+PqN1LZ4nrl8cvb527Lnbdu1yoAF rmJXuKkbgD2GfM/IQMfGNUm/ZWsSZRZ2TJPtNSsU5aFeJArsYDT3tOWcoXKfArPYJs xnjOZLxNmlbNwNDsM9gMWE1UqXGqmoTtkbdRAxmo= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A94D6EC58 for ; Thu, 27 May 2021 01:05:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A94D6EC58 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1lm1e7-0002Zf-6O; Thu, 27 May 2021 01:04:59 +0300 Date: Thu, 27 May 2021 01:04:54 +0300 To: Cyrill Gorcunov Message-ID: <20210526220454.twurat7647tcx4be@tkn_work_nb> References: <20210507111305.564935-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210507111305.564935-1-gorcunov@gmail.com> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9157EECD0FDB90B9AD87DBA6411CAD026194B5F22AB310E8D00894C459B0CD1B9DF42E090DDC8EFE29771E0D1691D81681BDB3D24A749B17D7EDAE2B993BF3920 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BCC85671EC7A750CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376F978168E59B07A5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D40411316C0BD8EA40F2C621AB6F933E333ECC7F00164DA146DAFE8445B8C89999728AA50765F790063707A1F3761B83B09E389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC84B6F6234D9065C97F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C29C2079CDE5AC980040F9FF01DFDA4A84AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3CC06CF5CFB199D65BA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE73E100E078FDA6C0F731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831B50151B22CADE19B86445F3BB20A73D6 X-C1DE0DAB: 0D63561A33F958A5CFF1F32C91A14CEB6A265C7E17F9A76443EA8080C4ADCE6BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA755C623DA9A0966939410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34980A6B448CFD1B8AD47DCE6411F59047EA2A2CC9D0C337FBE809A39EB1AA5503273EC68C4644C5651D7E09C32AA3244C6322362A10252AEE4C20962CE176E1C664EE5813BBCA3A9D927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiWl9Rlzdedm3S3TBMO3xVw== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADEDF42E090DDC8EFE29771E0D1691D8168B7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sorry for the late response. Looks nice! LGTM. If you'll have a free time, it would be good to add a simple test case: just to automatically verify it for regressions in a future. WBR, Alexander Turenko. On Fri, May 07, 2021 at 02:13:05PM +0300, Cyrill Gorcunov wrote: > Currently `log` module accepts only numeric values of > logging levels. I turn `box.cfg` interface supports > symbolic names (such as 'fatal', 'crit' and etc). > > Thus we should support the same in `log` module. > > Closes #5882 > > Reported-by: Alexander Turenko > Signed-off-by: Cyrill Gorcunov > --- > issue https://github.com/tarantool/tarantool/issues/5882 > branch gorcunov/gh-5882-logger-strings > > <...>