Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] iproto: stringify IPROTO_RAFT, IPROTO_PROMOTE
Date: Mon, 24 May 2021 09:47:09 +0000	[thread overview]
Message-ID: <20210524094709.itgqh45ym3wmsc77@tarantool.org> (raw)
In-Reply-To: <20210520213812.50976-1-gorcunov@gmail.com>

Hello,

On 21 май 00:38, Cyrill Gorcunov wrote:
> This allows `xlog` Lua module to decode appropriate
> types into symbolic form.
> 
> For example with the patch we should see raft and
> promote types in output.
> 
>  | $ tarantoolctl cat 00000000000000000004.xlog
>  | ---
>  | HEADER:
>  |   lsn: 2
>  |   group_id: 1
>  |   type: RAFT
>  |   timestamp: 1621541912.4588
>  | BODY:
>  |   0: 3
>  |   1: 4
>  | ---
>  | HEADER:
>  |   lsn: 1
>  |   replica_id: 4
>  |   type: PROMOTE
>  |   timestamp: 1621541912.4592
>  | BODY:
>  |   2: 0
>  |   3: 0
>  |   83: 3
> 
> Fixes #6088

I've checked your patch into 2.8 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2021-05-24  9:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 21:38 Cyrill Gorcunov via Tarantool-patches
2021-05-22 13:50 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-24  8:47 ` Serge Petrenko via Tarantool-patches
2021-05-24  9:47 ` Kirill Yukhin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524094709.itgqh45ym3wmsc77@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=kyukhin@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] iproto: stringify IPROTO_RAFT, IPROTO_PROMOTE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox